Code uses non-C99 compliant constructs

[michael-o]

1. What versions are you using?

Oracle Client 19/Oracle Database 10 SE2

2. Is it an error or a hang or a crash?

Does not properly build

3. What error(s) or behavior you are seeing?

This is Cython fix for oracle/odpi#205. Change is here: main...michael-o:python-oracledb:c99-compliance

Works on LLVM and HP aCC.

You can simulate the issue on LLVM or GCC by setting: EXTRA_CFLAGS ?= -std=c99 -pedantic

[anthony-tuininga]

As noted on the ODPI-C issue, this requires a major release of ODPI-C, which in turn means a major release of python-oracledb. So this will be postponed until that takes place.

[michael-o]

You can cherry-pick 3b46495 already, this does not require any new major version.

[anthony-tuininga]

I have pushed the necessary changes to ODPI-C and have initated a build from which you can download pre-built development wheels once it completes. You can also build from source if you prefer. If you can test your scenario and confirm the patch works as expected, that would be appreciated!

[michael-o]

Thank you, I will happily do and let you know.