Commit cf89c8a
committed
feat: instance record management improvements
Previously, the instance resource was responsible for creating, updating
and deleting the instance record in Etcd. This led to a corner case in
our disaster recovery process when we need to remove an instance
resource without executing its lifecyce methods.
This commit shifts the responsibility for creating and deleting the
instance records to the workflows. Now, we will create or update the
instance record to indicate the operation we're about to perform.
We only completely delete the instance records if the database operation
was successful.
The instance resource still updates the instance record to indicate an
available or failed status with an error.
PLAT-3981 parent 06352a5 commit cf89c8a
17 files changed
Lines changed: 345 additions & 240 deletions
File tree
- api/apiv1
- design
- gen/http
- client
- server/internal
- database
- workflows
- activities
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| 165 | + | |
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments