Skip to content

Batch Maintenance Release: CC BY-NC #1369

@brent-phet

Description

@brent-phet

Main Issue: https://github.com/phetsims/special-ops/issues/318

Associated Issues:

Overview

The primary focus of this MR is to support the migration to CC BY-NC licensing with the following changes to each simulation:

In addition, the following items have been included due to their urgency:

What to Test

AboutDialog (https://github.com/phetsims/special-ops/issues/318)

  • Click an RC link then click the PhET logo or 3 vertical dots in bottom right hand corner, then click "About..."
    • Dialog not go off the screen
    • Ensure text/license is correct - PhET brand should reference CC BY-NC 4.0, PhET-iO should only reference PhET-iO
    • Links should be blue, with an underline, and should work
    • Copyright final year is correct (Copyright in About dialog is inaccurate. joist#962)
    • Build timestamp (under sim version) should look correct.
    • Close the about dialog (no error - re-opening dialog is fine)
    • Are the links in the about dialog keyboard-accessible (a11y) - [JO/JG need to sync on this first]
  • Switch to a different locale, then return to About
    • The top Title, Version and The Simulation is Up to Date text should change to match the locale.
    • The bottom links for Translation Credits and Third party Credits should change to match the locale.
  • Add ?allowLinks=false, then return to About
    • The links should have URLs spelled out and not be clickable

Navbar (https://github.com/phetsims/special-ops/issues/318)

  • PhET brand has a vertical line to the left of phet-button
  • Vertical line appears on the home screen AND all additional screens
  • Vertical line appears on an inverted-color navbar (either by screen default OR in options check projector mode)
  • DOES the vertical line extend too far down?

Built HTML/XHTML

PhET-iO

  • Click the PhET_iO RC Link BELOW
    • PhET-iO brand does NOT have the vertical line in the Navbar
  • Load PhET-iO version with assertions (?phetioAssert=true) and Open the About dialog and Check the console and make sure it didn't crash or show error messages.
  • Load PhET-iO Studio and Open the About dialog. Check the console and make sure it didn't crash,
  • Load the Migration wrapper and test against the previous published minor version: SEE Migration RC LINKS BELOW - 11 Versions to Test)
    • In the old (top) version, open the About dialog, then click Migrate Now.
    • Change a string value, click Migrate Now.
    • Hide an element, then click Migrate Now.

PhET Studio

  • Load a PhET Studio preset that was created by the previous sim version (previous maintenance release), into this new simulation, as follows:
    • Go to https://phet.colorado.edu/admin/studio/sandbox
    • Enter the sim name/version that as it runs from the PhET website, for example membrane-transport 1.0. (This loads 1.0.3)
    • Launch PhET Studio, customize it, and click "Save Preset".
    • Click "Launch preset" and confirm the Customization saved.
  • Now we will launch PhET Studio with the lib file of the RC version we are testing (one maintenance version in the future). Like https://phet-dev.colorado.edu/html/membrane-transport/1.0.4/phet-io/lib/phet-io.js (modify this url for the sim version being tested)
    • Go to https://phet.colorado.edu/admin/studio/sandbox
    • Check "Load last saved preset from localStorage"
    • Enter the sim name/version that as it runs from the PhET website, for example membrane-transport 1.0. (This loads 1.0.3) Enter the lib file as you would in another test
    • Click "Launch PhET Studio"
    • This should successfully load the previous state (for immediately prior test above) into the new version of the sim.
    • Click "Save Preset" and Inspect for errors
    • Open the AboutDialog at least twice.
      • Test the 5 links in the About Dialog
        • Licensing
        • Privacy Policy
        • Translation Credits
        • Third-party Credits
        • Donate to PhET

Release Candidate links

#1369 (comment)

NOTE: Old PhET-iO versions were marked inactive - tracked in https://github.com/phetsims/phet-io/issues/2036 and only PhET-iO Hydrogen sims are to be included (ALL OTHERS ARE STRIKETHROUGH BELOW). The total is 60 PhET-IO sims versions tracked here.

For testing the Migration wrappers for prior versions ("Not Latest"), these are the relevant simulations and versions (except where strikethrough):

  • beers-law-lab 1.7 -> 1.8
  • center-and-variability 1.1 -> 1.2
  • circuit-construction-kit-dc 1.3 -> 1.4
  • circuit-construction-kit-dc-virtual-lab 1.3 -> 1.4
  • concentration 1.7 -> 1.8
  • density 1.1 -> 1.2
  • forces-and-motion-basics 2.5 -> 2.6
  • graphing-quadratics 1.3 -> 1.4
  • gravity-and-orbits 1.5 -> 1.6 (1.5 is NOT Hydrogen)
  • greenhouse-effect 1.0 (Only immediately prior minor version is relevant for migration)
  • greenhouse-effect 1.2 -> 1.3
  • natural-selection 1.3 (Only immediately prior minor version is relevant for migration)
  • number-pairs 1.0 (Only immediately prior minor version is relevant for migration)
  • ph-scale 1.6 -> 1.7
  • ph-scale-basics 1.6 -> 1.7

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions