Fix docblock indentation loss when fixing empty enclosing line (#52)

* Fix docblock indentation loss when fixing empty enclosing line

When EmptyEnclosingLine sniff fixed empty lines after class opening
brace, it removed all tokens including the newline that should remain.
Combined with other fixers (like DisallowTabIndent that converts tabs
to spaces), this caused the first content line (typically a docblock)
to lose its indentation entirely.

The fix explicitly preserves one newline after the opening brace by
replacing the first token with a newline character, then removing
the remaining tokens up to the content line.

* Add tests for tabs indentation preservation

Adds test cases to verify that the EmptyEnclosingLine sniff
correctly preserves indentation when removing empty lines
after class opening braces, particularly when using tabs.

Author: dereuromark

PhpCollective/Sniffs/WhiteSpace/EmptyEnclosingLineSniff.php

@@ -91,7 +91,9 @@ public function process(File $phpcsFile, $stackPtr): void
                 if ($contentLine < $braceLine + 1) {
                     $phpcsFile->fixer->addNewline($curlyBraceStartIndex);
                 } else {
-                    for ($i = $curlyBraceStartIndex + 1; $i < $beginningOfLine - 1; $i++) {
+                    // Replace first token with newline, remove the rest
+                    $phpcsFile->fixer->replaceToken($curlyBraceStartIndex + 1, $phpcsFile->eolChar);
+                    for ($i = $curlyBraceStartIndex + 2; $i < $beginningOfLine; $i++) {
                         $phpcsFile->fixer->replaceToken($i, '');
                     }
                 }

tests/PhpCollective/Sniffs/WhiteSpace/EmptyEnclosingLineSniffTest.php

@@ -27,4 +27,31 @@ public function testEmptyEnclosingLineFixer(): void
     {
         $this->assertSnifferCanFixErrors(new EmptyEnclosingLineSniff());
     }
+
+    /**
+     * Tests that tabs are preserved when fixing empty enclosing line.
+     *
+     * @return void
+     */
+    public function testTabsPreservedSniffer(): void
+    {
+        $this->prefix = 'tabs-';
+        $this->assertSnifferFindsErrors(new EmptyEnclosingLineSniff(), 1);
+        $this->prefix = null;
+    }
+
+    /**
+     * Tests fixer preserves indentation with tabs.
+     *
+     * This test verifies the fix for the bug where indentation was lost
+     * when removing empty lines after opening braces.
+     *
+     * @return void
+     */
+    public function testTabsPreservedFixer(): void
+    {
+        $this->prefix = 'tabs-';
+        $this->assertSnifferCanFixErrors(new EmptyEnclosingLineSniff());
+        $this->prefix = null;
+    }
 }

tests/_data/EmptyEnclosingLine/tabs-after.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types = 1);
+
+namespace PhpCollective;
+
+class TabsTest {
+	/**
+	 * @param string $foo The foo.
+	 *
+	 * @return void
+	 */
+	public function one(string $foo): void
+	{
+		echo $foo;
+	}
+}

tests/_data/EmptyEnclosingLine/tabs-before.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace PhpCollective;
+
+class TabsTest {
+
+	/**
+	 * @param string $foo The foo.
+	 *
+	 * @return void
+	 */
+	public function one(string $foo): void
+	{
+		echo $foo;
+	}
+}