From 45824ade988eb98fcbe19fab10ad8922a8c484d2 Mon Sep 17 00:00:00 2001 From: mscherer Date: Fri, 10 Apr 2026 17:54:50 +0200 Subject: [PATCH 1/3] Add Universal attribute and whitespace sniffs Covers gaps in current ruleset for PHP 8 attributes and whitespace: Attributes: - Universal.Attributes.BracketSpacing - Universal.Attributes.DisallowAttributeParentheses - Universal.Attributes.TrailingComma Whitespace: - Universal.WhiteSpace.AnonClassKeywordSpacing - Universal.WhiteSpace.FirstClassCallableSpacing - Universal.WhiteSpace.DisallowInlineTabs --- PhpCollective/ruleset.xml | 6 ++++++ docs/sniffs.md | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/PhpCollective/ruleset.xml b/PhpCollective/ruleset.xml index 724fcc4..081c179 100644 --- a/PhpCollective/ruleset.xml +++ b/PhpCollective/ruleset.xml @@ -252,6 +252,12 @@ + + + + + + diff --git a/docs/sniffs.md b/docs/sniffs.md index 3adcf0b..3f29935 100644 --- a/docs/sniffs.md +++ b/docs/sniffs.md @@ -1,7 +1,7 @@ # PhpCollective Code Sniffer -The PhpCollectiveStrict standard contains 245 sniffs +The PhpCollectiveStrict standard contains 251 sniffs Generic (27 sniffs) ------------------- @@ -268,8 +268,11 @@ Squiz (27 sniffs) - Squiz.WhiteSpace.SemicolonSpacing - Squiz.WhiteSpace.SuperfluousWhitespace -Universal (12 sniffs) +Universal (18 sniffs) --------------------- +- Universal.Attributes.BracketSpacing +- Universal.Attributes.DisallowAttributeParentheses +- Universal.Attributes.TrailingComma - Universal.CodeAnalysis.ConstructorDestructorReturn - Universal.CodeAnalysis.ForeachUniqueAssignment - Universal.CodeAnalysis.NoEchoSprintf @@ -280,7 +283,10 @@ Universal (12 sniffs) - Universal.Operators.ConcatPosition - Universal.Operators.TypeSeparatorSpacing - Universal.UseStatements.NoUselessAliases +- Universal.WhiteSpace.AnonClassKeywordSpacing - Universal.WhiteSpace.CommaSpacing +- Universal.WhiteSpace.DisallowInlineTabs +- Universal.WhiteSpace.FirstClassCallableSpacing - Universal.WhiteSpace.PrecisionAlignment Zend (1 sniff) From cf47c33d5d89693b8469697f29578394313276f4 Mon Sep 17 00:00:00 2001 From: mscherer Date: Fri, 10 Apr 2026 17:59:25 +0200 Subject: [PATCH 2/3] Bump phpcsextra to ^1.5.0 for new attribute/whitespace sniffs --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 4505a50..5df868a 100644 --- a/composer.json +++ b/composer.json @@ -19,7 +19,7 @@ ], "require": { "php": ">=8.1", - "phpcsstandards/phpcsextra": "^1.4.1", + "phpcsstandards/phpcsextra": "^1.5.0", "slevomat/coding-standard": "^8.23.0", "squizlabs/php_codesniffer": "^4.0.0" }, From 497a1e35407c2bf6f99767a86141919d264704dd Mon Sep 17 00:00:00 2001 From: Mark Scherer Date: Fri, 10 Apr 2026 18:05:48 +0200 Subject: [PATCH 3/3] Update php_codesniffer version to ^4.0.1 --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 5df868a..21eab3c 100644 --- a/composer.json +++ b/composer.json @@ -21,7 +21,7 @@ "php": ">=8.1", "phpcsstandards/phpcsextra": "^1.5.0", "slevomat/coding-standard": "^8.23.0", - "squizlabs/php_codesniffer": "^4.0.0" + "squizlabs/php_codesniffer": "^4.0.1" }, "require-dev": { "phpstan/phpstan": "^2.0.0",