Skip to content

Commit e4f2ee9

Browse files
dunglasCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
1 parent 015a996 commit e4f2ee9

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

docs/docker.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ RUN install-php-extensions pdo_mysql pdo_pgsql #...
223223
224224
# Copy shared libs of frankenphp and all installed extensions to temporary location
225225
# You can also do this step manually by analyzing ldd output of frankenphp binary and each extension .so file
226-
RUN apt-get update; \
227-
apt-get install -y --no-install-recommends libtree; \
228-
mkdir -p /tmp/libs; \
226+
RUN apt-get update && \
227+
apt-get install -y --no-install-recommends libtree && \
228+
mkdir -p /tmp/libs && \
229229
for target in $(which frankenphp) \
230230
$(find "$(php -r 'echo ini_get("extension_dir");')" -maxdepth 2 -name "*.so"); do \
231231
libtree -pv "$target" 2>/dev/null | grep -oP '(?:── )\K/\S+(?= \[)' | while IFS= read -r lib; do \
@@ -251,8 +251,8 @@ ENV XDG_CONFIG_HOME=/config XDG_DATA_HOME=/data
251251
COPY --from=builder --chown=nonroot:nonroot /data /data
252252
COPY --from=builder --chown=nonroot:nonroot /config /config
253253
254-
# Copy your app and Caddyfile
255-
COPY --chown=nonroot:nonroot . /app
254+
# Copy your app (kept root-owned) and Caddyfile
255+
COPY . /app
256256
COPY Caddyfile /etc/caddy/Caddyfile
257257
258258
USER nonroot

0 commit comments

Comments
 (0)