Skip to content

Commit 5d66d28

Browse files
committed
Add clean history slide GH-47
1 parent 174736a commit 5d66d28

3 files changed

Lines changed: 22 additions & 0 deletions

File tree

lectures/14_code_review.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,16 @@ based on: [Code Review Guidelines for Humans](https://phauer.com/2018/code-revie
524524
source: [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/) [@beams2014how]
525525
:::
526526

527+
## keeping clean history
528+
529+
![](figures/user_statistics/branching.svg){width=850}
530+
531+
::: {.text-smaller .fragment}
532+
- features are often developed on separate feature branches
533+
- after a feature is completed, the branch is merged
534+
- as a feature branch may contain too much commits (detail)
535+
- commits on a feature branch often squashed into one commit
536+
:::
527537

528538
# review in numbers
529539

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
gitGraph
2+
commit id: "Display avatar #17"
3+
commit id: "Display username #18"
4+
commit id: "Add progress bar #19"
5+
branch "feature: activity"
6+
checkout "feature: activity"
7+
commit id: "Add activity matrix #20"
8+
commit id: "Set color map to Greens #20"
9+
commit id: "Display labels #20"
10+
checkout main
11+
merge "feature: activity"
Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)