Cannot override `enableGlobalVirtualStore`

[colinaaa]

We would like to use all the defaults from @pnpm/plugin-better-defaults but change enableGlobalVirtualStore to false:

# pnpm-workspace.yaml
configDependencies:
  "@pnpm/plugin-better-defaults": 0.1.0+sha512-aWj7Jv9NcNs/OoazrxP6QspLgKRZ2PHj6wPris6ZCEqmXw+Z8zK59KLzl9NBFGRCO4PNA9pwDWLu+8N3NiqUAQ==

# Overrides
enableGlobalVirtualStore: false

We are expecting to get enableGlobalVirtualStore: false, but enableGlobalVirtualStore: true is what we got.

plugin-better-defaults/pnpmfile.cjs

Lines 3 to 5 in d939539

	updateConfig (config) {
	Object.assign(config, {
	enableGlobalVirtualStore: true,

[zkochan]

You should be able to override it by creating your own .pnpmfile.cjs, where you set it to false.

[zkochan]

What issues do you have with enableGlobalVirtualStore: true? I'd like to look into them if you have any.

Actually, we need to combine this plugin with https://github.com/pnpm/plugin-esm-node-path/tree/main to reduce issues with enableGlobalVirtualStore

Related PR: #3

[colinaaa]

You should be able to override it by creating your own .pnpmfile.cjs, where you set it to false.

Thank you for this tip. But as this plugin is called better-defaults, it is expected to only change the default value and can be easily overrided.

[colinaaa]

What issues do you have with enableGlobalVirtualStore: true?

A lot of module not found. I do have tried plugin-esm-node-path, but it doesn't seem to work.

I haven't have time for a repro yet, but you may try it out at https://github.com/lynx-family/lynx-stack/pull/1454/commits

Here are some easy ones:

1. ts-patch is missing typescript as peerDependencies/dependencies

. prepare$ husky && ts-patch install
│ node:internal/modules/cjs/loader:1365
│   const err = new Error(message);
│               ^
│ Error: Cannot find module 'typescript'
│ Require stack:
│ - /Users/colin/Library/pnpm/store/v10/links/ts-patch/3.3.0/d8a5ae051b43c5b6292da1dfd6a68321b…
...

This could be solved by using packageExtension as you documented.

2. enableGlobalVirtualStore: true is enabled on CI

As you can see at https://github.com/lynx-family/lynx-stack/actions/runs/16796991529/job/47570580187

I'm not sure if it's related with the self hosted runner that we are using.

3. Something related with npm alias

We have a fokred version of preact, which is installed as

{
  "dependencies": {
    "preact": "npm:@hongzhiyuan/preact@10.24"
  }
}

And there are code like

// preact/compat.js
import {} from 'preact' // <--- We did not change this to `@hongzhiyuan/preact`

Witout enableGlobalVirtualStore: true, the would somehow being hoisted to .pnpm/<XXX>/node_modules/preact/, at where Node.js could resolve the preact.
But with global virtual store, the preact could never be found :)

This could be solved by adding preact to hoistPattern, just like what I've done in lynx-family/lynx-stack@0332225

[colinaaa]

We also have some tests related with the error stack, after setting enableGlobalVirtualStore: true, it would give diff like this:

- Module build failed (from ../../../../../node_modules/<PNPM_INNER>/sass-loader/dist/cjs.js):
+ Module build failed (from ../../../../../../Library/pnpm/store/v10/links/sass-loader/16.0.5/426cb78f11663601b2b70cdda9fdd081a551028dcfc4d85ec4f56996a378c164/node_modules/sass-loader/dist/cjs.js):

The <PNPM_INNER> is replaced by https://github.com/rspack-contrib/path-serializer

And having different value of enableGlobalVirtualStore would make it impossible to write tests like this (although we would also have enableGlobalVirtualStore: true on CI as described above).

We may need the same replacement for global virtual store, but it would take some time. So I finally decided to revert it