Skip to content

Commit 4b16ef8

Browse files
committed
rename from in XLogWrapper to be more descriptive considering List<List<String>> can overlap with List<?>
1 parent eaf9bcb commit 4b16ef8

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

src/org/processmining/placebasedlpmdiscovery/model/logs/XLogWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public XLogWrapper(XLog log) {
2222
this.log = log;
2323
}
2424

25-
public static XLogWrapper from(List<List<String>> traces) {
25+
public static XLogWrapper fromListOfTracesAsListStrings(List<List<String>> traces) {
2626
XFactory factory = XFactoryRegistry.instance().currentDefault();
2727
XLog log = factory.createLog();
2828

tests-integration/TestPlaceBasedLPMDiscoveryGivenLogAbcWithPlacesAbAc.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static void setup() {
2828
places.add(Place.from("a | c"));
2929
placesProvider = PlacesProvider.fromSet(places);
3030

31-
XLogWrapper logWrapper = XLogWrapper.from(Collections.singletonList( // QA: maybe there is a better way for this
31+
XLogWrapper logWrapper = XLogWrapper.fromListOfTracesAsListStrings(Collections.singletonList(
3232
Arrays.asList("a", "b", "c")
3333
));
3434
eventLog = logWrapper.getOriginalLog();
@@ -40,7 +40,6 @@ public void givenDefault_whenFrom_thenLPMsAbAc() {
4040
LPMDiscovery lpmDiscovery = new PlaceBasedLPMDiscovery(placesProvider);
4141

4242
// when
43-
// QA: should from method accept EventLog instead of XLog?
4443
LPMDiscoveryResult result = lpmDiscovery.from(eventLog);
4544

4645
// then

0 commit comments

Comments
 (0)