Skip to content

Commit 03ec5c8

Browse files
tannewttannewt
committed
Changes based on Dan's feedback
1 parent 928e6bc commit 03ec5c8

File tree

35 files changed

+152
-127
lines changed

35 files changed

+152
-127
lines changed

‎ports/analog/common-hal/busio/I2C.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
187187
}
188188

189189
// Write data to the device selected by address
190-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
190+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
191191
const uint8_t *data, size_t len) {
192192

193193
int ret;
@@ -209,7 +209,7 @@ mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
209209
}
210210

211211
// Read into buffer from the device selected by address
212-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self,
212+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self,
213213
uint16_t addr,
214214
uint8_t *data, size_t len) {
215215

@@ -233,7 +233,7 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self,
233233
}
234234

235235
// Write the bytes from out_data to the device selected by address
236-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
236+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
237237
uint8_t *out_data, size_t out_len,
238238
uint8_t *in_data, size_t in_len) {
239239

‎ports/atmel-samd/common-hal/busio/I2C.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
176176
self->has_lock = false;
177177
}
178178

179-
static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
179+
static mp_negative_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
180180
const uint8_t *data, size_t len, bool transmit_stop_bit) {
181181

182182
uint16_t attempts = ATTEMPTS;
@@ -202,12 +202,12 @@ static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t ad
202202
return -MP_EIO;
203203
}
204204

205-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
205+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
206206
const uint8_t *data, size_t len) {
207207
return _common_hal_busio_i2c_write(self, addr, data, len, true);
208208
}
209209

210-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
210+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
211211
uint8_t *data, size_t len) {
212212

213213
uint16_t attempts = ATTEMPTS;
@@ -233,9 +233,9 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
233233
return -MP_EIO;
234234
}
235235

236-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
236+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
237237
uint8_t *out_data, size_t out_len, uint8_t *in_data, size_t in_len) {
238-
mp_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
238+
mp_negative_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
239239
if (result != 0) {
240240
return result;
241241
}

‎ports/atmel-samd/common-hal/sdioio/SDCard.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ static void debug_print_state(sdioio_sdcard_obj_t *self, const char *what, sd_mm
171171
#endif
172172
}
173173

174-
mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
174+
mp_negative_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
175175
uint32_t start_block, uint32_t num_blocks) {
176176
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
177177
wait_write_complete(self);
@@ -189,7 +189,7 @@ mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
189189
return 0;
190190
}
191191

192-
mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
192+
mp_negative_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
193193
check_for_deinit(self);
194194
check_whole_block(bufinfo);
195195

@@ -198,7 +198,7 @@ mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint3
198198
start_block, num_blocks);
199199
}
200200

201-
mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
201+
mp_negative_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
202202
uint32_t start_block, uint32_t num_blocks) {
203203
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
204204
wait_write_complete(self);
@@ -216,7 +216,7 @@ mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
216216
return 0;
217217
}
218218

219-
mp_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
219+
mp_negative_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
220220
check_for_deinit(self);
221221
check_whole_block(bufinfo);
222222

‎ports/broadcom/common-hal/busio/I2C.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
137137

138138
// Discussion of I2C implementation is here: https://github.com/raspberrypi/linux/issues/254
139139

140-
static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
140+
static mp_negative_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
141141
const uint8_t *data, size_t len, bool transmit_stop_bit) {
142142
COMPLETE_MEMORY_READS;
143143
self->peripheral->S_b.DONE = true;
@@ -192,12 +192,12 @@ static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t ad
192192
return 0;
193193
}
194194

195-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
195+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
196196
const uint8_t *data, size_t len) {
197197
return _common_hal_busio_i2c_write(self, addr, data, len, true);
198198
}
199199

200-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
200+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
201201
uint8_t *data, size_t len) {
202202
COMPLETE_MEMORY_READS;
203203
self->peripheral->A_b.ADDR = addr;
@@ -242,9 +242,9 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
242242
return 0;
243243
}
244244

245-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
245+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
246246
uint8_t *out_data, size_t out_len, uint8_t *in_data, size_t in_len) {
247-
mp_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
247+
mp_negative_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
248248
if (result != 0) {
249249
return result;
250250
}

‎ports/broadcom/common-hal/sdioio/SDCard.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ static void check_whole_block(mp_buffer_info_t *bufinfo) {
306306
}
307307

308308
// Native function for VFS blockdev layer
309-
mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
309+
mp_negative_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
310310
uint32_t start_block, uint32_t num_blocks) {
311311
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
312312
if (!self->init) {
@@ -327,7 +327,7 @@ mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
327327
return 0;
328328
}
329329

330-
mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
330+
mp_negative_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
331331
if (!self->init) {
332332
return -MP_EIO;
333333
}
@@ -339,7 +339,7 @@ mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint3
339339
}
340340

341341
// Native function for VFS blockdev layer
342-
mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
342+
mp_negative_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
343343
uint32_t start_block, uint32_t num_blocks) {
344344
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
345345
if (!self->init) {
@@ -358,7 +358,7 @@ mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
358358
return 0;
359359
}
360360

361-
mp_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
361+
mp_negative_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
362362
if (!self->init) {
363363
return -MP_EIO;
364364
}

‎ports/cxd56/common-hal/busio/I2C.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ bool common_hal_busio_i2c_probe(busio_i2c_obj_t *self, uint8_t addr) {
9191
return I2C_TRANSFER(self->i2c_dev, &msg, 1) < 0 ? false : true;
9292
}
9393

94-
static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t address, const uint8_t *data, size_t len, bool stop) {
94+
static mp_negative_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t address, const uint8_t *data, size_t len, bool stop) {
9595
struct i2c_msg_s msg;
9696

9797
msg.frequency = self->frequency;
@@ -102,12 +102,12 @@ static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t ad
102102
return -I2C_TRANSFER(self->i2c_dev, &msg, 1);
103103
}
104104

105-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
105+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
106106
const uint8_t *data, size_t len) {
107107
return _common_hal_busio_i2c_write(self, addr, data, len, true);
108108
}
109109

110-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t address, uint8_t *data, size_t len) {
110+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t address, uint8_t *data, size_t len) {
111111
struct i2c_msg_s msg;
112112

113113
msg.frequency = self->frequency;
@@ -118,9 +118,9 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t address, ui
118118
return -I2C_TRANSFER(self->i2c_dev, &msg, 1);
119119
}
120120

121-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
121+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
122122
uint8_t *out_data, size_t out_len, uint8_t *in_data, size_t in_len) {
123-
mp_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
123+
mp_negative_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
124124
if (result != 0) {
125125
return result;
126126
}

‎ports/cxd56/common-hal/sdioio/SDCard.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ static void check_whole_block(mp_buffer_info_t *bufinfo) {
9797
}
9898

9999
// Native function for VFS blockdev layer
100-
mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
100+
mp_negative_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
101101
uint32_t start_block, uint32_t num_blocks) {
102102
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
103103
int result = self->inode->u.i_bops->read(self->inode, buf, start_block, num_blocks);
@@ -107,7 +107,7 @@ mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
107107
return 0;
108108
}
109109

110-
mp_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
110+
mp_negative_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
111111
if (common_hal_sdioio_sdcard_deinited(self)) {
112112
raise_deinited_error();
113113
}
@@ -119,7 +119,7 @@ mp_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32
119119
}
120120

121121
// Native function for VFS blockdev layer
122-
mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
122+
mp_negative_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
123123
uint32_t start_block, uint32_t num_blocks) {
124124
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
125125
int result = self->inode->u.i_bops->write(self->inode, buf, start_block, num_blocks);
@@ -129,7 +129,7 @@ mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
129129
return 0;
130130
}
131131

132-
mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
132+
mp_negative_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
133133
if (common_hal_sdioio_sdcard_deinited(self)) {
134134
raise_deinited_error();
135135
}

‎ports/espressif/common-hal/busio/I2C.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
169169
self->has_lock = false;
170170
}
171171

172-
static mp_errno_t convert_esp_err(esp_err_t result) {
172+
static mp_negative_errno_t convert_esp_err(esp_err_t result) {
173173
switch (result) {
174174
case ESP_OK:
175175
return 0;
@@ -189,7 +189,7 @@ static size_t _transaction_duration_ms(size_t frequency, size_t len) {
189189
return (len + 1) / bytes_per_ms + 1000;
190190
}
191191

192-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr, const uint8_t *data, size_t len) {
192+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr, const uint8_t *data, size_t len) {
193193
i2c_device_config_t dev_config = {
194194
.dev_addr_length = I2C_ADDR_BIT_LEN_7,
195195
.device_address = addr,
@@ -202,7 +202,7 @@ mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr, cons
202202
return convert_esp_err(result);
203203
}
204204

205-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr, uint8_t *data, size_t len) {
205+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr, uint8_t *data, size_t len) {
206206
i2c_device_config_t dev_config = {
207207
.dev_addr_length = I2C_ADDR_BIT_LEN_7,
208208
.device_address = addr,
@@ -215,7 +215,7 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr, uint8
215215
return convert_esp_err(result);
216216
}
217217

218-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
218+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
219219
uint8_t *out_data, size_t out_len, uint8_t *in_data, size_t in_len) {
220220
i2c_device_config_t dev_config = {
221221
.dev_addr_length = I2C_ADDR_BIT_LEN_7,

‎ports/espressif/common-hal/sdioio/SDCard.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ static void check_whole_block(mp_buffer_info_t *bufinfo, int sector_size) {
169169
}
170170
}
171171

172-
mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
172+
mp_negative_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
173173
uint32_t start_block, uint32_t num_blocks) {
174174
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
175175
ESP_LOGI(TAG, "in sdioio_sdcard_writeblocks");
@@ -181,7 +181,7 @@ mp_errno_t sdioio_sdcard_writeblocks(mp_obj_t self_in, uint8_t *buf,
181181
return 0;
182182
}
183183

184-
mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
184+
mp_negative_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
185185
common_hal_sdioio_sdcard_check_for_deinit(self);
186186
check_whole_block(bufinfo, self->card.csd.sector_size);
187187

@@ -190,7 +190,7 @@ mp_errno_t common_hal_sdioio_sdcard_writeblocks(sdioio_sdcard_obj_t *self, uint3
190190
start_block, num_blocks);
191191
}
192192

193-
mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
193+
mp_negative_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
194194
uint32_t start_block, uint32_t num_blocks) {
195195
sdioio_sdcard_obj_t *self = MP_OBJ_TO_PTR(self_in);
196196
ESP_LOGI(TAG, "in sdioio_sdcard_readblocks");
@@ -202,7 +202,7 @@ mp_errno_t sdioio_sdcard_readblocks(mp_obj_t self_in, uint8_t *buf,
202202
return 0;
203203
}
204204

205-
mp_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
205+
mp_negative_errno_t common_hal_sdioio_sdcard_readblocks(sdioio_sdcard_obj_t *self, uint32_t start_block, mp_buffer_info_t *bufinfo) {
206206
common_hal_sdioio_sdcard_check_for_deinit(self);
207207
check_whole_block(bufinfo, self->card.csd.sector_size);
208208

‎ports/mimxrt10xx/common-hal/busio/I2C.c‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ void common_hal_busio_i2c_unlock(busio_i2c_obj_t *self) {
201201
self->has_lock = false;
202202
}
203203

204-
static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
204+
static mp_negative_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
205205
const uint8_t *data, size_t len, bool transmit_stop_bit) {
206206

207207
lpi2c_master_transfer_t xfer = { 0 };
@@ -218,12 +218,12 @@ static mp_errno_t _common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t ad
218218
return -MP_EIO;
219219
}
220220

221-
mp_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
221+
mp_negative_errno_t common_hal_busio_i2c_write(busio_i2c_obj_t *self, uint16_t addr,
222222
const uint8_t *data, size_t len) {
223223
return _common_hal_busio_i2c_write(self, addr, data, len, true);
224224
}
225225

226-
mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
226+
mp_negative_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
227227
uint8_t *data, size_t len) {
228228

229229
lpi2c_master_transfer_t xfer = { 0 };
@@ -240,9 +240,9 @@ mp_errno_t common_hal_busio_i2c_read(busio_i2c_obj_t *self, uint16_t addr,
240240
return -MP_EIO;
241241
}
242242

243-
mp_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
243+
mp_negative_errno_t common_hal_busio_i2c_write_read(busio_i2c_obj_t *self, uint16_t addr,
244244
uint8_t *out_data, size_t out_len, uint8_t *in_data, size_t in_len) {
245-
mp_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
245+
mp_negative_errno_t result = _common_hal_busio_i2c_write(self, addr, out_data, out_len, false);
246246
if (result != 0) {
247247
return result;
248248
}

0 commit comments

Comments
 (0)