Skip to content

Commit dae495f

Browse files
authored
Merge pull request adafruit#10772 from dhalbert/10.0.x-fix-espcamera-reconfigure
espressif_bindings/Camera.c: fix type of framebuffer_count
2 parents 5a80d6f + 0caa9ed commit dae495f

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
cp-version: ${{ needs.scheduler.outputs.cp-version }}
108108

109109
mpy-cross-mac:
110-
runs-on: macos-13
110+
runs-on: macos-latest
111111
needs: scheduler
112112
if: needs.scheduler.outputs.ports != '{}'
113113
env:
@@ -131,33 +131,18 @@ jobs:
131131
gcc --version
132132
python3 --version
133133
msgfmt --version
134-
- name: Build mpy-cross
135-
run: make -C mpy-cross -j4
136-
- uses: actions/upload-artifact@v4
137-
with:
138-
name: mpy-cross-macos-x64
139-
path: mpy-cross/build/mpy-cross
140134
- name: Build mpy-cross (arm64)
141135
run: make -C mpy-cross -j4 -f Makefile.m1 V=2
142136
- uses: actions/upload-artifact@v4
143137
with:
144138
name: mpy-cross-macos-arm64
145139
path: mpy-cross/build-arm64/mpy-cross-arm64
146-
- name: Make universal binary
147-
run: lipo -create -output mpy-cross-macos-universal mpy-cross/build/mpy-cross mpy-cross/build-arm64/mpy-cross-arm64
148-
- name: Upload artifact
149-
uses: actions/upload-artifact@v4
150-
with:
151-
name: mpy-cross-macos-universal
152-
path: mpy-cross-macos-universal
153140
- name: Upload to S3
154141
if: >-
155142
(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository_owner == 'adafruit') ||
156143
(github.event_name == 'release' && (github.event.action == 'published' || github.event.action == 'rerequested'))
157144
run: |
158-
[ -z "$AWS_ACCESS_KEY_ID" ] || aws s3 cp mpy-cross-macos-universal s3://adafruit-circuit-python/bin/mpy-cross/macos/mpy-cross-macos-"${CP_VERSION}"-universal --no-progress --region us-east-1
159145
[ -z "$AWS_ACCESS_KEY_ID" ] || aws s3 cp mpy-cross/build-arm64/mpy-cross-arm64 s3://adafruit-circuit-python/bin/mpy-cross/macos/mpy-cross-macos-"${CP_VERSION}"-arm64 --no-progress --region us-east-1
160-
[ -z "$AWS_ACCESS_KEY_ID" ] || aws s3 cp mpy-cross/build/mpy-cross s3://adafruit-circuit-python/bin/mpy-cross/macos/mpy-cross-macos-"${CP_VERSION}"-x64 --no-progress --region us-east-1
161146
env:
162147
AWS_PAGER: ''
163148
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}

ports/espressif/bindings/espcamera/Camera.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ static mp_obj_t espcamera_camera_reconfigure(mp_uint_t n_args, const mp_obj_t *p
261261
args[ARG_grab_mode].u_obj != MP_ROM_NONE
262262
? validate_grab_mode(args[ARG_grab_mode].u_obj, MP_QSTR_grab_mode)
263263
: common_hal_espcamera_camera_get_grab_mode(self);
264-
bool framebuffer_count =
264+
mp_int_t framebuffer_count =
265265
args[ARG_framebuffer_count].u_obj != MP_ROM_NONE
266266
? mp_obj_get_int(args[ARG_framebuffer_count].u_obj)
267267
: common_hal_espcamera_camera_get_framebuffer_count(self);

0 commit comments

Comments
 (0)