Add Windows support for idlelib/help.py‎

[benediktjohannes]

My suggestion is to change d = data if self.pre else data.replace('\n', ' ') to d = data if self.pre else data.replace('\n', ' ').replace('\r', ' ') in order to include windows support

[picnixz]

This doesn't explain anything. Please develop the idea. I would recommend that you carefully read https://devguide.python.org/getting-started/pull-request-lifecycle/ before opening future PRs.

[picnixz]

Why is this change necessary? why doesn't it work currently? what is self.pre? with IDLE, it's important that you include visual comparisons as well so that we know whether the change is useful.

[benediktjohannes]

Thanks! I'll read that carefully!

[StanFromIreland]

I just noticed the PR, as such I'm closing. help.html will never have carriage returns as we control its generation, so there is nothing to strip:

cpython/Lib/idlelib/help.py

Line 283 in 01a1dd2

if copy: out.write(line.strip() + '\n')

Please don't open such PRs that are purely based on speculation.

[terryjreedy]

pre is True/False as the html data chunk is within/without an html 'pre' (preformatted) tag block. Outside such spans, newlines are arbitrarily placed and should be ignored so the text can be wrapped according the window width.

The code line # is 151, within the handle_data method of HelpParser.

@benediktjohannes Please include such details in a report. Even better is a direct link. This was created by going to https://github.com/python/cpython/blob/main/Lib/idlelib/help.py#L151 from the cpython page, selecting the line, clicking the (...) added in front, and selecting Copy permalink. (And if you got the suggestion from an 'AI', know that the initials also stands for 'artificial inanity/insantity'. Don't copy from such without careful review.) One can ask about possible bugs by posting on the Help channel at https://discuss.python.org.

[benediktjohannes]

Hi @terryjreedy thank you very much for the detailed information!