links to rendered drafts are added to bottom page navigation when `website:draft-mode: unlinked`

[prncevince]

I have:

• searched the issue tracker for similar issues
• installed the latest version of Quarto CLI
• formatted my issue following the Bug Reports guide

Bug description

Draft html documents are added to the page navigation when website:draft-mode is set to unlinked.

2nd screenshot below shows hovered link to the linked rendered draft.

Also see repro:

• https://github.com/prncevince/test-quarto-draft-mode-page-navigation
  And deployed website with issue. See link at bottom on blog post:
• https://prncevince.github.io/test-quarto-draft-mode-page-navigation/posts/post-with-code/

Steps to reproduce

Creating a blank blog, then adding to the following configuration to _quarto.yml can reproduce this:

draft-mode: unlinked, page-navigation: true, a sidebar containing blog posts & 1 draft.

e.g.

Run: quarto create project blog ., copy 1 blog post to new directory under posts & set draft: true in yaml, then edit _quarto.yml to the following:

project:
  type: website

website:
  title: "Demo"
  navbar:
    right:
      - about.qmd
      - icon: github
        href: https://github.com/
      - icon: twitter
        href: https://twitter.com
  draft-mode: unlinked
  sidebar:
    contents:
      - section: Blog 
        contents: posts/*/*
  page-navigation: true
format:
  html:
    theme: cosmo
    css: styles.css

Actual behavior

Rendered drafts are linked in the page navigation. Config option website:draft-mode:unlinked should remove them.

Expected behavior

When draft: true for html documents in a website, the rendered draft should not be added to the page navigation.

Your environment

• OS: MacOS Sonoma 14.6.1

Quarto check output

quarto v1.9.17

[mcanouil]

Important

Accessibility: To improve accessibility, please add alternative text to your screenshots. This helps all users, including those using screen readers, to understand the context of the images. A brief description can make a big difference! See Good Alt Text, Bad Alt Text — Making Your Content Perceivable.

[prncevince]

I've also tested this for website:draft-mode: gone. Bottom link page navigation is added for drafts as well with this config setting as well, except the drafts simply are not rendered (e.g. the page navigation link is to a blank html document).

[mcanouil]

The next/previous links are computed at a different level and directly from the sidebar, thus why draft are still listed there.

• quarto-cli/src/project/types/website/website-navigation.ts

  Lines 1187 to 1226 in 6c8a9b1

  	function nextAndPrevious(
  	href: string,
  	sidebar?: Sidebar,
  	): NavigationPagination {
  	if (sidebar?.contents) {
  	const sidebarItems = flattenItems(
  	sidebar?.contents,
  	(item: SidebarItem) => {
  	// Only include items that have a link that isn't external
  	return item.href !== undefined && !isExternalPath(item.href) ||
  	isSeparator(item);
  	},
  	);
  	// Don't allow the same href to appear in the flattened list multiple times
  	const sidebarItemsUniq = ld.uniqBy(
  	sidebarItems,
  	(sidebarItem: SidebarItem) => {
  	return sidebarItem.href || Math.random().toString();
  	},
  	) as SidebarItem[];
  	const index = sidebarItemsUniq.findIndex((item) => item.href === href);
  	const nextPage = index > -1 && index < sidebarItemsUniq.length - 1 &&
  	!isSeparator(sidebarItemsUniq[index + 1])
  	? sidebarItemsUniq[index + 1]
  	: undefined;
  	const prevPage = index > -1 && index <= sidebarItemsUniq.length - 1 &&
  	!isSeparator(sidebarItemsUniq[index - 1])
  	? sidebarItemsUniq[index - 1]
  	: undefined;
  	return {
  	nextPage,
  	prevPage,
  	};
  	} else {
  	return {};
  	}
  	}

This function needs to also account for the draft-mode.