Skip to content

Add Light mode and adaptive colour scheme by default #840

@myfonj

Description

@myfonj

Quite a follow-up for #62 that seems to address a limited subset of requirements: mainly calls for the "native-looking" chrome controls with better contrast against other windows in the default (dark) theme.

Eulogy for theme duality

I strongly favour keeping everything adaptive to the actual system preference, so I can use light mode by day, dark at night. Support for the adaptive colour scheme inheriting from the OS is one of the few better modern trends in app design.

Hotfix through settings.json?

I am not sure if manual tweaks of the settings.json with

    "workbench.colorCustomizations": {
        "[*Dark*]": { /*...*/ },
        "[*Light*]": { /*...*/ }
    }

could really affect the whole GUI at this point (?), since some colours seem to be hardcoded and not adopted from the theme (?). This issue is basically call for either the fully "themeable" Windhawk app (with good defaults), or two fixed rigid themes with sufficient contrasts everywhere.


P.S.: Blue is too dark, semi-transparent is dangerous

Also tangentially related: the current dark theme used across the app and the website features very dark "accent" blue colour used for links and buttons (#177ddc) that has very poor contrast against the near-black background (#1e1e1e), it does not even pass WCAG guidelines. It could barely pass having pitch black background, but I'd argue that on monitor with very low brightness the resulting contrast is still unreadable. Same applies for the semi-transparent texts that fails in "features" body texts and barely passes in the "Featured mods" boxes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions