forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Bug
PR #320 added hasCommittedChanges check in spawnAdversarial — if no committed changes in the worktree, adversarial is skipped and developer is respawned. But developer-pipeline.txt lines 17 and 101 explicitly forbid git commit:
- Line 17:
❌ Make git commits or push code — pipeline handles this - Line 101:
❌ git add, git commit, git push (pipeline handles this)
This deadlocks the pipeline: developer writes code but cannot commit, so hasCommittedChanges always returns false, developer gets respawned forever.
Fix
The developer MUST commit locally in the worktree. The pipeline's ops-pipeline does the final push/merge to the feature branch — but local worktree commits are the developer's responsibility.
Update developer-pipeline.txt:
- Line 17: change to
✅ git add + git commit in your worktree (do NOT push) - Line 101: change
❌ git add, git commit, git pushto❌ git push (pipeline handles this) - Add explicit commit step in the Workflow section after checks pass
Acceptance Criteria
- developer-pipeline.txt allows
git addandgit commit(but notgit push) - Workflow section step 10 explicitly says: commit your changes before signalling done
- No other changes needed
- Adversarial: APPROVED
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working