From c5013d4e39e919137d059f1a304d34ae6110d854 Mon Sep 17 00:00:00 2001 From: Freddy Harris Date: Wed, 18 Mar 2026 20:27:39 +0100 Subject: [PATCH 1/2] getElementById could return null --- src/DOMAPI/Document.res | 2 +- src/DOMAPI/DocumentFragment.res | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DOMAPI/Document.res b/src/DOMAPI/Document.res index 1a496db..d5cb276 100644 --- a/src/DOMAPI/Document.res +++ b/src/DOMAPI/Document.res @@ -15,7 +15,7 @@ Returns the first element within node's descendants whose ID is elementId. [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getElementById) */ @send -external getElementById: (document, string) => element = "getElementById" +external getElementById: (document, string) => null = "getElementById" /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getAnimations) diff --git a/src/DOMAPI/DocumentFragment.res b/src/DOMAPI/DocumentFragment.res index 203903f..7862a98 100644 --- a/src/DOMAPI/DocumentFragment.res +++ b/src/DOMAPI/DocumentFragment.res @@ -38,7 +38,7 @@ Returns the first element within node's descendants whose ID is elementId. [Read more on MDN](https://developer.mozilla.org/docs/Web/API/DocumentFragment/getElementById) */ @send - external getElementById: (T.t, string) => element = "getElementById" + external getElementById: (T.t, string) => null = "getElementById" /** Inserts nodes before the first child of node, while replacing strings in nodes with equivalent Text nodes. From d9d26072bd6058b0ee92b016e064d7226ca9b14b Mon Sep 17 00:00:00 2001 From: Freddy Harris Date: Wed, 18 Mar 2026 20:28:34 +0100 Subject: [PATCH 2/2] getSelection could return null --- src/DOMAPI/Document.res | 2 +- src/DOMAPI/Window.res | 2 +- src/Global.res | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/DOMAPI/Document.res b/src/DOMAPI/Document.res index d5cb276..c74ae5f 100644 --- a/src/DOMAPI/Document.res +++ b/src/DOMAPI/Document.res @@ -442,7 +442,7 @@ Returns an object representing the current selection of the document that is loa [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getSelection) */ @send -external getSelection: document => selection = "getSelection" +external getSelection: document => null = "getSelection" /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/hasStorageAccess) diff --git a/src/DOMAPI/Window.res b/src/DOMAPI/Window.res index 2d16381..f4f8c27 100644 --- a/src/DOMAPI/Window.res +++ b/src/DOMAPI/Window.res @@ -514,4 +514,4 @@ external cancelIdleCallback: (window, int) => unit = "cancelIdleCallback" [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/getSelection) */ @send -external getSelection: window => selection = "getSelection" +external getSelection: window => null = "getSelection" diff --git a/src/Global.res b/src/Global.res index 8405eef..9ce9545 100644 --- a/src/Global.res +++ b/src/Global.res @@ -744,4 +744,4 @@ external cancelIdleCallback: int => unit = "cancelIdleCallback" /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/getSelection) */ -external getSelection: unit => selection = "getSelection" +external getSelection: unit => null = "getSelection"