From 2a2bb9e61cd1f2c2aabb0e49e9cf772bbadc80c6 Mon Sep 17 00:00:00 2001 From: Soutaro Matsumoto Date: Wed, 25 Mar 2026 13:44:30 +0900 Subject: [PATCH 1/2] Use `echo` instead of `env` for Windows --- test/stdlib/Open3_test.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/stdlib/Open3_test.rb b/test/stdlib/Open3_test.rb index 639bfcaaa9..a64c4364c1 100644 --- a/test/stdlib/Open3_test.rb +++ b/test/stdlib/Open3_test.rb @@ -43,9 +43,9 @@ def test_popen2 assert_send_type "(*::String) -> [ ::IO, ::IO, ::Process::Waiter ]", Open3, :popen2, 'echo "Foo"' assert_send_type "(*::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen2, 'env', unsetenv_others: true + Open3, :popen2, 'echo "Foo"', unsetenv_others: true assert_send_type "(*::String, close_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen2, 'env', close_others: true + Open3, :popen2, 'echo "Foo"', close_others: true assert_send_type "(*::String, chdir: ::String) -> [ ::IO, ::IO, ::Process::Waiter ]", Open3, :popen2, 'echo "Foo"', chdir: '.' assert_send_type "(::Hash[::String, ::String], ::String) -> [ ::IO, ::IO, ::Process::Waiter ]", @@ -61,9 +61,9 @@ def test_popen3 assert_send_type "(::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", Open3, :popen3, 'echo "Foo"' assert_send_type "(::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen3, 'env', unsetenv_others: true + Open3, :popen3, 'echo "Foo"', unsetenv_others: true assert_send_type "(::String, close_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen3, 'env', close_others: true + Open3, :popen3, 'echo "Foo"', close_others: true assert_send_type "(::String, chdir: ::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", Open3, :popen3, 'echo "Foo"', chdir: '.' assert_send_type "(::Hash[::String, ::String], ::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", From 7504ccd398a88c34ff1c13438819d3b4cc86dfc8 Mon Sep 17 00:00:00 2001 From: Soutaro Matsumoto Date: Wed, 25 Mar 2026 14:30:37 +0900 Subject: [PATCH 2/2] unsetenv_others: false --- test/stdlib/Open3_test.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/stdlib/Open3_test.rb b/test/stdlib/Open3_test.rb index a64c4364c1..02d0f0a015 100644 --- a/test/stdlib/Open3_test.rb +++ b/test/stdlib/Open3_test.rb @@ -43,7 +43,7 @@ def test_popen2 assert_send_type "(*::String) -> [ ::IO, ::IO, ::Process::Waiter ]", Open3, :popen2, 'echo "Foo"' assert_send_type "(*::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen2, 'echo "Foo"', unsetenv_others: true + Open3, :popen2, 'echo "Foo"', unsetenv_others: false assert_send_type "(*::String, close_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]", Open3, :popen2, 'echo "Foo"', close_others: true assert_send_type "(*::String, chdir: ::String) -> [ ::IO, ::IO, ::Process::Waiter ]", @@ -61,7 +61,7 @@ def test_popen3 assert_send_type "(::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", Open3, :popen3, 'echo "Foo"' assert_send_type "(::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", - Open3, :popen3, 'echo "Foo"', unsetenv_others: true + Open3, :popen3, 'echo "Foo"', unsetenv_others: false assert_send_type "(::String, close_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]", Open3, :popen3, 'echo "Foo"', close_others: true assert_send_type "(::String, chdir: ::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",