Filtering uploaded files

[Zexbe]

When dealing with crates, the site should check that they are a sane size, and file type before uploading them. Ex: 100gb video should be blocked.

[jyn514]

Relevant code: https://github.com/rust-lang/docs.rs/blob/master/src/db/file.rs#L190

[Kixiron]

What seems like a reasonable file size limit @jyn514?

[syphar]

From what I understand, a 100 GB video file could only end up in docs.rs, if it was previously uploaded to crates.io too, which I assume has reasonable limits.

I could imagine that macro generated docs could reach sizes that are bigger (megabytes?), so some limit is perhaps helpful to releave the server.

[syphar]

If I'm not missing anything, I would close this issue based on my last comment.

Since we're streaming the content from the zip files to the browser, rustdoc file size is not too bug of an issue.

If it's about source files,

• for text based files, we render them into the HTML, where our existing max file size kicks in
• if it's binary files, we'll stream them anyways, so also not an issue.

Feel free to comment / reopen if I'm missing something.

[jyn514]

@syphar you probably want to also close #794, then.

[syphar]

true :)