It is impossible to understand from the readme file how to supress lints using clippy.toml

[iddm]

It is impossible to understand from the readme file how to disable some lints using clippy.toml, it seems to be explained only for nightly compiler and touching the code. I suggest to add an example of disabling some lints using clippy.toml for rust stable (let's take single_match for example) into the readme.

[flip1995]

It is not possible to disable lints in the clippy.toml. You have to either add #[allow(clippy::lint_name/group)] in front of the item you want to disable the lint for or #![allow(clippy::lint_name/group)] to the beginning of your lib.rs file.

For stable see also: #3159

clippy.toml will probably be deprecated with Clippy 1.0. See rust-lang/rfcs#2476 (comment) and #3013

[iddm]

So I am obligated either to have a feature called "cargo-clippy" for this:

#![cfg_attr(feature = "cargo-clippy", feature(tool_lints))]
#[cfg_attr(feature = "cargo-clippy", warn(clippy::single_match))]

or to use nightly. I doubt an ordinary user wants to change his code. Why can't we do that without touching the code at all? It had been okay when it was allowed to use clippy.toml. If this is going to be deprecated, why not to also leave us with something that can be treated as equal replacement?

Also, I still don't see this information in the README file which every user sees and where it can only see this information. My opinion is that it should be added there. Don't you think the opposite, do you, @flip1995 ?

[phansch]

@vityafx Regarding the replacement for the clippy.toml, there is work being done to manage lints via Cargo.toml. The lint configuration is being moved to cargo because that allows users to manage rustc lints as well and it's one less configuration file to manage.

[iddm]

@phansch The cargo will always warn that there are unused sections in the Cargo.toml if we put something unknown to cargo. Also, this is still WIP while the old way can not be used already, sounds unfair.

[mati865]

@vityafx clippy.toml from the start wasn't meant to disable lints. It just allows to configure some of them.
Until Cargo supports lints configuration there will be a way configure lints but it's not agreed yet.

[flip1995]

@vityafx The cargo-clippy feature workaround is only temporary until tool_lints are stable. It will only be one line people need to add to their code:

#![cfg_attr(feature="cargo-clippy", feature(tool_lints))]

allowing or denying lints was always in the code. Also the cfg_attr(cargo-clippy, ...) attribute was always necessary for Clippy lints. We're currently moving to tool_lints to avoid needing the cargo-clippy feature. Sadly this cannot be done within a few days.

---

You're right about the tool_lint part missing in the README. The tool_lints change landed about a week ago and I didn't get to update the README yet. But it needs an update, everyone who wants to help with that is invited to do so!

[iddm]

It would be nice if we did not have to add anything to the source code. Okay, whatever, you'll not listen to me as a user.

[flip1995]

Sadly this is not possible #3159 (comment). If you have a better solution how this could be implemented, feel free to suggest it or open an rustc PR.

Reminder: #2718 (comment)

[Manishearth]

@vityafx I don't think clippy.toml ever supported flipping lint levels, you seem to be under the impression that we did and removed that ability. There is no "old way", the in-source attributes are the old way. The new way will eventually be through Cargo, and work is being done in that already. I'm not sure what we can do here to help you.

[iddm]

@Manishearth Yes, I had thought so until you told me. Anyway, this is must have feature - to be able to use clippy without touching the code, even Cargo.toml, in my opinion. Also, it is interesting to me how you are going to deal with cargo warnings about unknown fields in the Cargo.toml?

[Manishearth]

We'll probably use [lints.clippy] or some such, similarly to how the clippy:: lint attributes are completely ignored by the compiler when clippy is not in use.

If you want to set lint levels on clippy without touching any code, pass -A flags to clippy itself.