`rust-analyzer` went into the wrong dir (maybe?)

[chenzhuoyu]

Summary

Building the HEAD version (e0be1a02626abef2878cb7f4aaef7ae409477112 as I'm writing this issue) with:

./x.py build --stage 2 library rustfmt clippy rust-analyzer

causes the rust-analyzer binary goes into stage1-tools-bin rather than stage2-tools-bin

Command used

./x.py build --stage 2 library rustfmt clippy rust-analyzer

Then find the rust-analyzer

find . -type f -name 'rust-analyzer'

Expected behaviour

According to rustc-dev-guide, the rust-analyzer should be built with the stage2 compiler, thus we should find it in stage2-tools-bin

Actual behaviour

The rust-analyzer is found in stage1-tools-bin

Bootstrap configuration (config.toml)

profile = "compiler"
change-id = 137215

[llvm]
assertions = true
release-debuginfo = true
download-ci-llvm = false

Operating system

ArchLinux x86_64

HEAD

e0be1a02626abef2878cb7f4aaef7ae409477112

Additional context

Yes, we do have custom patches, but not within the build system, so we think it's irrelevant for this issue.

This issue does not occure until recent days, the rust-analyzer binary was always found in stage2-tools-bin, but it suddenly moved to stage1-tools-bin, is this the expected behavior?

[onur-ozkan]

This issue does not occure until recent days, the rust-analyzer binary was always found in stage2-tools-bin, but it suddenly moved to stage1-tools-bin, is this the expected behavior?

It is the expected behavior. Previously, it was unnecessarily building an extra stage. #137215 fixed that incorrect logic. You should look in the stageN/bin directory not stageN-tools-bin. In your case, you can find the binaries under stage2/bin.

[chenzhuoyu]

@onur-ozkan But rust-analyzer is only found in stage1-tools-bin, not in stage2/bin. So what is the intended way to get a custom-built rust-analyzer?

[onur-ozkan]

I see it looks like you are only building rust-analyzer. rust-analyzer is a compiler tool and its staging logic is very similar to how we build rustc. When you build stage1 rustc it's first built in stage0 artifacts and then copied to the stage1 directory. The same applies to rustc tools. The stage1-bin-tool/rust-analyzer is actually the stage2 rust-analyzer. (I know the naming is confusing but that's how it works for now).

[chenzhuoyu]

@onur-ozkan Oh, that makes sense. Thanks so much 😊

[chenzhuoyu]

@onur-ozkan It looks like that I also get a wrong clippy ....

[chenzhuoyu]

@onur-ozkan This is clippy-driver, not clippy ... Which causes cargo clippy to fail after rustup toolchain link ...

$ cargo clippy
error: couldn't read `clippy`: No such file or directory (os error 2)

error: aborting due to 1 previous error

[onur-ozkan]

That was a bug and thanks for reporting it. #137541 should fix that.