Rustc segfaults with -C passes=livestacks

[ruuda]

How to reproduce:

mkdir /tmp/repro
cd /tmp/repro
cargo init --bin
mkdir .cargo
echo '[build]\nrustflags = ["-C", "passes=livestacks"]' > .cargo/config
cargo build --verbose

Output:

   Compiling repro v0.1.0 (file:///tmp/repro)
     Running `rustc --crate-name repro src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=10c9440624901274 -C extra-filename=-10c9440624901274 --out-dir /tmp/repro/target/debug/deps -L dependency=/tmp/repro/target/debug/deps -C passes=livestacks`
error: Could not compile `repro`.

Caused by:
  process didn't exit successfully: `rustc --crate-name repro src/main.rs --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=10c9440624901274 -C extra-filename=-10c9440624901274 --out-dir /tmp/repro/target/debug/deps -L dependency=/tmp/repro/target/debug/deps -C passes=livestacks` (signal: 11, SIGSEGV: invalid memory reference)

The livestacks pass is listed by rustc -C passes=list.

Reproduces on 1.21 and nightly:

rustc --version
rustc 1.21.0 (3b72af97e 2017-10-09)
rustc +nightly --version
rustc 1.24.0-nightly (1956d5535 2017-12-03)

[ruuda]

passes=stack-coloring results in the same issue.

[nagisa]

Almost surely a LLVM crash.

[nikic]

The problem here is that livestacks is a machine function pass, but we're adding it to the main optimization pass manager. We already have code that distinguishes pass kinds and rejects those we do not (currently) support, but it is based on PassKind, which does not distinguish between function passes and machine function passes.

[Enselic]

From nightly-2021-09-26 the segfault is gone, probably because of #88243. Instead you get this error:

error: failed to run LLVM passes: unknown pass name 'livestacks'

Other potential commits are (click to expand):

$ git log  ^73422130ee96c09e7214c876a3600ac1f32aa8c8  addb4da686a97da46159f0123cb6cdc2ce3d7fdb --no-merges --oneline
67065fe9336 Apply 16 commits (squashed)
51203dc1c40 Pin panic-in-drop=abort test to old pass manager
31834434a0b Make expectation in panic-in-drop-abort.rs test more precise
074bbc6b878 Use correct pipeline for LTO at O0
be01f42f731 Enable new pass manager on LLVM 13
ab64580977c Bless tests
19eaee2c329 Report heap allocation instead of non-const fn for exchange_malloc call
511333fcc41 Use Rvalue::ShallowInitBox for box expression
c38da2e0a32 Introduce `Rvalue::ShallowInitBox`
f1e71a5b41a arrr caught ya caller
85f02901a3c Stabilize `feature(macro_attributes_in_derive_output)`
92804cd4901 derive: Do not configure or clone items unless necessary
c993984e4d5 builtin_macros: Make #[derive(A, B, ...)] cfg-eval its input only for `A, B, ...`
cb6c13977aa Make error message for malformed `fn`/`fn_mut` lang item more specific
27213b02544 Disable some tests for platforms without registers.
dd918048a56 Update and add more tests
4337089098e Add basic checks for well-formedness of `fn`/`fn_mut` lang items
6d218d02d9e Add inline asm! tests for aarch64
a307dcc9626 Add 1.56.0 release notes
ed3b751799b Give better error for `macro_rules! name!`
cebba31d4ae unitalicize O(1) complexities
9fa59e19e51 Enable "generate-link-to-definition" option on rust tools docs as well
389365631d3 Fix tidy and respond to some feedback
b146525140a remove trailing whitespace
d63e0f0e477 Add time complexities to linked_list.rs
ab8aef40b1e Drop fully captured upvars in the same order as the regular drop code
7a3e450df45 Add tests to verify the drop order of fields in fully captured upvars
0222556c077 Simplify scoped_thread
df727490b6a Make SymbolIndex private
4e0ee2a1bab Avoid a couple of Symbol::as_str calls in cg_llvm
9886c233d84 Remove Symbol::len
553f6496f29 Fix clippy
b73c8b823f8 Fix rustdoc
c065f571117 Remove ToPolyTraitRef impl for TraitRef
be76bdf9058 Remove ToPredicate impls that use Binder::dummy

I wouldn't mind this issue being closed as obsolete, but it would be nice with a regression test I guess.