Discussing some of the difficulties with #54528 with @nikomatsakis led them to remind me that we originally introduced #[rustc_error] because we didn't have a way to express // compile-pass to the test infrastructure.
But now we do
and it would make sense for us to try to migrate instances of #[rustc_error] to use // compile-pass when possible.
(I think the main case where it is not possible are instances of // revisions where at least one of the revisions compiles successfully and another does not.)
Discussing some of the difficulties with #54528 with @nikomatsakis led them to remind me that we originally introduced
#[rustc_error]because we didn't have a way to express// compile-passto the test infrastructure.But now we do
and it would make sense for us to try to migrate instances of
#[rustc_error]to use// compile-passwhen possible.(I think the main case where it is not possible are instances of
// revisionswhere at least one of the revisions compiles successfully and another does not.)