feat(toolchain): run a pre-check before updating all toolchains

Author: FranciscoTGouveia

src/cli/common.rs

@@ -10,13 +10,14 @@ use std::{cmp, env};
 use anstyle::Style;
 use anyhow::{Context, Result, anyhow};
 use clap_cargo::style::{CONTEXT, ERROR, UPDATE_ADDED, UPDATE_UNCHANGED, UPDATE_UPGRADED};
+use futures_util::future::join_all;
 use git_testament::{git_testament, render_testament};
 use tracing::{error, info, warn};
 use tracing_subscriber::{EnvFilter, Registry, reload::Handle};
 
 use crate::{
     config::Cfg,
-    dist::{DistOptions, TargetTriple, ToolchainDesc},
+    dist::{DistOptions, TargetTriple, ToolchainDesc, manifest::Manifest},
     errors::RustupError,
     install::{InstallMethod, UpdateStatus},
     process::Process,
@@ -213,11 +214,27 @@ fn show_channel_updates(
 
 pub(crate) async fn update_all_channels(cfg: &Cfg<'_>, force_update: bool) -> Result<ExitCode> {
     let profile = cfg.get_profile()?;
+    let channels = cfg.list_channels()?;
+
+    // Run a pre-check to determine which channels have updates available.
+    let prefetched_manifests: Vec<Option<(Manifest, String)>> =
+        join_all(channels.iter().map(|(_, d)| d.fetch_dist_manifest()))
+            .await
+            .into_iter()
+            .map(|r| r.unwrap_or(None))
+            .collect();
+
     let mut toolchains = Vec::new();
-    for (desc, distributable) in cfg.list_channels()? {
-        let options = DistOptions::new(&[], &[], &desc, profile, force_update, cfg)?
-            .for_update(&distributable, false);
-        let result = InstallMethod::Dist(options).install().await;
+    for ((desc, distributable), manifest) in channels.into_iter().zip(prefetched_manifests) {
+        let result = if force_update || manifest.is_some() {
+            let options = DistOptions::new(&[], &[], &desc, profile, force_update, cfg)?
+                .for_update(&distributable, false);
+            InstallMethod::Dist(options)
+                .install_with_manifest(manifest)
+                .await
+        } else {
+            Ok(UpdateStatus::Unchanged)
+        };
 
         if let Err(e) = &result {
             error!("{e}");

tests/suite/cli_rustup.rs

@@ -97,7 +97,6 @@ async fn rustup_stable_no_change() {
 
 "#]])
         .with_stderr(snapbox::str![[r#"
-info: syncing channel updates for stable-[HOST_TRIPLE]
 info: cleaning up downloads & tmp directories
 
 "#]])
@@ -210,7 +209,6 @@ info: syncing channel updates for stable-[HOST_TRIPLE]
 info: latest update on 2015-01-02 for version 1.1.0 (hash-stable-1.1.0)
 info: removing previous version of component cargo
 ...
-info: syncing channel updates for beta-[HOST_TRIPLE]
 info: syncing channel updates for nightly-[HOST_TRIPLE]
 info: latest update on 2015-01-02 for version 1.3.0 (hash-nightly-2)
 info: removing previous version of component cargo

tests/suite/cli_rustup_ui/rustup_update_no_change.stderr.term.svg

@@ -690,7 +690,6 @@ async fn rustup_self_update_exact() {
 
 "#]])
         .with_stderr(snapbox::str![[r#"
-info: syncing channel updates for stable-[HOST_TRIPLE]
 info: checking for self-update (current version: [CURRENT_VERSION])
 info: downloading self-update (new version: [TEST_VERSION])
 info: cleaning up downloads & tmp directories