SizeOf on a reference to a package doesn't work

[martin-hughes]

Firstly, I assume it should do? Based on this bit from the spec:

SizeOfTerm :=
    SizeOf (
    DataObject // SuperName => <string | buffer | package>
    ) => Integer

Calling do_size_of on a reference to a package fails with ParseFail(InvalidOperationOnObject { op: SizeOf, typ: Package }) (remembering typ is also the cause of #272, and noting that the match statement does normally handle Object::Package)

If you agree that it should work, @IsaacWoods, then this should be a straightforward fix in do_size_of - or could be rolled up into the other References work.

[IsaacWoods]

Yes this should work. typ has turned out to be a bit of a nightmare - I almost wonder if it should leave references as-is and we should have a more verbose version to go through to the underlying type.

I think this should be a case of changing https://github.com/rust-osdev/acpi/blob/main/src/aml/mod.rs#L2204 to unwrap real references too?

Edit: thank you for your recent work on the crate @martin-hughes! Your thorough testing has found all sorts of issues.

[martin-hughes]

No worries at all - it's keeping me occupied during an on-call week! My thoughts are:

• typ has its uses - particularly for building AmlErrors
  • although - personal style here - I'd probably make an impl From<WrappedObject> for ObjectType {}, since constructing ObjectType doesn't depend on any private field of WrappedObject
• If it were me, I'd probably rely more on destructuring the WrappedObject directly rather than using a separate-ish enum (although there's only two or three places this gets done at present) - then there's no risk of ObjectType contradicting the actual type

Let me code up a PR in that style to fix this issue and see if you like it. I'm building up a small stash of PRs! As always, no pressure - I should probably be doing the garden instead 😂