From 9fe9619935bd9acc294096635256e829de5d30ac Mon Sep 17 00:00:00 2001 From: Eric Willhoit Date: Mon, 26 Aug 2024 10:14:41 -0500 Subject: [PATCH] fix: use 1.0.0 on plugins and libs --- src/commands/dev/generate/library.ts | 1 + src/commands/dev/generate/plugin.ts | 5 +++-- src/types.ts | 1 + test/commands/dev/generate/plugin.nut.ts | 3 +++ 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/commands/dev/generate/library.ts b/src/commands/dev/generate/library.ts index 6143c622..ce95b9b8 100644 --- a/src/commands/dev/generate/library.ts +++ b/src/commands/dev/generate/library.ts @@ -80,6 +80,7 @@ export default class GenerateLibrary extends SfCommand { await generator.loadPjson(); generator.pjson.name = `${answers.scope}/${answers.name}`; + generator.pjson.version = '1.0.0'; generator.pjson.description = answers.description; generator.pjson.repository = `${answers.org}/${answers.name}`; generator.pjson.homepage = `https://github.com/${answers.org}/${answers.name}`; diff --git a/src/commands/dev/generate/plugin.ts b/src/commands/dev/generate/plugin.ts index f125a1ff..02ac6ea7 100644 --- a/src/commands/dev/generate/plugin.ts +++ b/src/commands/dev/generate/plugin.ts @@ -140,13 +140,14 @@ export default class GeneratePlugin extends SfCommand { name: `@salesforce/${answers.name}`, repository: `salesforcecli/${answers.name}`, homepage: `https://github.com/salesforcecli/${answers.name}`, - description: answers.description, } : { name: answers.name, - description: answers.description, }; + updated.version = '1.0.0'; + updated.description = answers.description; + if (answers.author) { updated.author = answers.author; } diff --git a/src/types.ts b/src/types.ts index 847b3fc4..75ce206f 100644 --- a/src/types.ts +++ b/src/types.ts @@ -25,6 +25,7 @@ export type NYC = { export type PackageJson = { name: string; + version: string; devDependencies: Record; dependencies: Record; files: string[]; diff --git a/test/commands/dev/generate/plugin.nut.ts b/test/commands/dev/generate/plugin.nut.ts index e057494b..06a1c144 100644 --- a/test/commands/dev/generate/plugin.nut.ts +++ b/test/commands/dev/generate/plugin.nut.ts @@ -40,6 +40,7 @@ describe('dev generate plugin NUTs', () => { const packageJson = readJson(packageJsonPath); expect(packageJson.name).to.equal('@salesforce/plugin-awesome'); + expect(packageJson.version).to.equal('1.0.0'); expect(packageJson.author).to.equal('Salesforce'); expect(packageJson.description).to.equal('a description'); expect(packageJson.bugs).to.equal('https://github.com/forcedotcom/cli/issues'); @@ -85,6 +86,7 @@ describe('dev generate plugin NUTs', () => { const packageJson = readJson(packageJsonPath); expect(packageJson.name).to.equal('my-plugin'); + expect(packageJson.version).to.equal('1.0.0'); expect(packageJson.author).to.equal('me'); expect(packageJson.description).to.equal('a description'); @@ -140,6 +142,7 @@ describe('dev generate plugin NUTs', () => { const packageJson = readJson(packageJsonPath); expect(packageJson.name).to.equal('my-plugin'); + expect(packageJson.version).to.equal('1.0.0'); expect(packageJson.author).to.equal('me'); expect(packageJson.description).to.equal('a description'); const nycConfig = readJson(path.join(session.dir, 'my-plugin', '.nycrc'));