Skip to content

Commit 556e28a

Browse files
abueideclaude
andcommitted
fix: increment droppedEventCount at SegmentDestination drop sites
Wire up the droppedEventCount counter (added in cli-flush-retry-loop) at the two places SegmentDestination permanently removes events: permanent errors and retry limit exceeded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent bd13cbd commit 556e28a

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

packages/core/src/plugins/SegmentDestination.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ export class SegmentDestination extends DestinationPlugin {
272272
await this.queuePlugin.dequeueByMessageIds(
273273
aggregation.permanentErrorMessageIds
274274
);
275+
this.droppedEventCount += aggregation.permanentErrorMessageIds.length;
275276
this.analytics?.logger.error(
276277
`Dropped ${aggregation.permanentErrorMessageIds.length} events due to permanent errors`
277278
);
@@ -281,6 +282,7 @@ export class SegmentDestination extends DestinationPlugin {
281282
await this.queuePlugin.dequeueByMessageIds(
282283
aggregation.retryableMessageIds
283284
);
285+
this.droppedEventCount += aggregation.retryableMessageIds.length;
284286
this.analytics?.logger.error(
285287
`Dropped ${aggregation.retryableMessageIds.length} events due to retry limit exceeded`
286288
);

0 commit comments

Comments
 (0)