-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
Scripts API support in #42 uses filesystem auto-discovery (scripts_dir/{entity_id}/{script_id}/metadata.json + script.bash). This works but scripts are managed=false (deletable via API).
Once selfpatch/ros2_medkit#303 lands (scripts section in entity manifest), migrate all 3 demos to use manifest-defined scripts for managed=true (immutable) semantics.
Proposed solution
- Add
scripts:section to each demo's entity manifest YAML (sensor_manifest.yaml,turtlebot3_manifest.yaml,panda_manifest.yaml) - Remove
container_scripts/directories from Dockerfiles (scripts defined in manifest, paths point to/opt/scripts/) - Update
medkit_params.yaml- may no longer needscripts_dirif all scripts are manifest-defined
Additional context
Depends on: selfpatch/ros2_medkit#303
Current implementation: filesystem auto-discovery in container_scripts/ dirs (PR from #42)
TODO markers in code reference this issue.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request