Fix Psalm-issue

tvdijen · tvdijen · commit 220f95aa2260 · 2019-03-25T21:05:44.000+01:00
diff --git a/lib/Auth/Source/X509userCert.php b/lib/Auth/Source/X509userCert.php
@@ -154,7 +154,8 @@ public function authenticate(&$state)
         }
 
         $ldap_certs = $ldapcf->getAttributes($dn, $this->ldapusercert);
-        if ($ldap_certs === false) {
+        
+        if (empty($ldap_certs)) {
             \SimpleSAML\Logger::error('authX509: no certificate found in LDAP for dn='.$dn);
             $state['authX509.error'] = "UNKNOWNCERT";
             $this->authFailed($state);

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,8 @@ public function authenticate(&$state)`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`$ldap_certs = $ldapcf->getAttributes($dn, $this->ldapusercert);`
`157`		`- if ($ldap_certs === false) {`
	`157`	`+`
	`158`	`+ if (empty($ldap_certs)) {`
`158`	`159`	`\SimpleSAML\Logger::error('authX509: no certificate found in LDAP for dn='.$dn);`
`159`	`160`	`$state['authX509.error'] = "UNKNOWNCERT";`
`160`	`161`	`$this->authFailed($state);`