Skip to content

Commit 2f83f87

Browse files
chore: address review comments
1 parent 977f4cb commit 2f83f87

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

apps/sim/components/emcn/components/button/button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const buttonVariants = cva(
2424
ghost: 'text-[var(--text-secondary)] hover-hover:text-[var(--text-primary)]',
2525
subtle:
2626
'text-[var(--text-body)] hover-hover:text-[var(--text-body)] hover-hover:bg-[var(--surface-4)]',
27-
'ghost-secondary': 'text-[var(--text-muted)]',
27+
'ghost-secondary': 'text-[var(--text-muted)] hover-hover:text-[var(--text-primary)]',
2828
/** Branded button - requires branded-button-gradient or branded-button-custom class for colors */
2929
branded:
3030
'rounded-[10px] border text-white hover-hover:text-white text-base transition-[transform,background-color,color,border-color] duration-200',

apps/sim/components/emcn/components/popover/popover.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,16 @@ const PopoverContent = React.forwardRef<
629629
...style,
630630
}}
631631
>
632-
{children}
632+
{showArrow ? (
633+
<div
634+
className='overflow-auto flex-1 flex flex-col'
635+
style={{ maxHeight: `${maxHeight || 400}px` }}
636+
>
637+
{children}
638+
</div>
639+
) : (
640+
children
641+
)}
633642
{showArrow && (
634643
<PopoverPrimitive.Arrow width={14} height={7} asChild>
635644
<svg
@@ -1202,4 +1211,4 @@ export {
12021211
usePopoverContext,
12031212
}
12041213

1205-
export type { PopoverSize, PopoverColorScheme }
1214+
export type { PopoverSize, PopoverColorScheme }

0 commit comments

Comments
 (0)