Skip to content

Commit 0602e8b

Browse files
committed
[Subtlety] Adjust Deepening Shadows Math
* Appears to use raw tooltip value for rating, not applied inversely * Currently also appears to ignore the ratings diminishing returns curve * Confirmed value is applied after The First Dance, removed TOCHECK
1 parent e6de5c4 commit 0602e8b

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

engine/class_modules/sc_rogue.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7135,14 +7135,16 @@ struct shadow_dance_t : public stealth_like_buff_t<buff_t>
71357135
bd += rogue->spec.the_first_dance_buff->effectN( 1 ).time_value();
71367136
}
71377137

7138-
// MIDNIGHT TOCHECK -- Is this just rating? Or base+rating? Is this before or after The First Dance?
7138+
// Current testing is that this applies the rating tooltip percentage value after TfD
71397139
if ( rogue->talent.subtlety.deepening_shadows->ok() )
71407140
{
71417141
double h = std::max( 0.0, rogue->composite_melee_haste_rating() ) / rogue->current.rating.attack_haste;
7142-
h = rogue->apply_combat_rating_dr( RATING_MELEE_HASTE, h );
7143-
h = 1.0 / ( 1.0 + h );
7144-
h *= rogue->current.melee_haste;
7145-
bd *= 1.0 + rogue->spec.deepening_shadows_buff->effectN( 3 ).percent() * ( 1.0 - h);
7142+
// 2026-04-08 -- Currently doesn't appear to use diminishing returns
7143+
if ( !rogue->bugs )
7144+
{
7145+
h = rogue->apply_combat_rating_dr( RATING_MELEE_HASTE, h );
7146+
}
7147+
bd *= 1.0 + rogue->spec.deepening_shadows_buff->effectN( 3 ).percent() * h;
71467148
}
71477149

71487150
return bd;

0 commit comments

Comments
 (0)