Skip to content

Commit f738d2a

Browse files
committed
✅ Fix run deletion tests
1 parent a9d8a7e commit f738d2a

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

tests/functional/test_client.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -291,20 +291,24 @@ def test_get_tag(create_plain_run: tuple[sv_run.Run, dict]) -> None:
291291

292292
@pytest.mark.dependency
293293
@pytest.mark.client(depends=PRE_DELETION_TESTS)
294-
def test_run_deletion(create_test_run: tuple[sv_run.Run, dict]) -> None:
295-
run, run_data = create_test_run
294+
def test_run_deletion() -> None:
295+
run = sv_run.Run()
296+
run.init(name="test_run_deletion", folder="/simvue_unit_testing", tags=["test_run_deletion"], retention_period="1 min")
297+
run.log_metrics({"x": 2})
296298
run.close()
297299
client = svc.Client()
298-
assert not client.delete_run(run_data["run_id"])
300+
assert not client.delete_run(run.id)
299301

300302

301303
@pytest.mark.dependency
302304
@pytest.mark.client(depends=PRE_DELETION_TESTS)
303-
def test_runs_deletion(create_test_run: tuple[sv_run.Run, dict]) -> None:
304-
run, run_data = create_test_run
305-
run.close()
305+
def test_runs_deletion() -> None:
306+
_runs = [sv_run.Run() for _ in range(5)]
307+
for i, run in enumerate(_runs):
308+
run.init(name="test_runs_deletion", folder="/simvue_unit_testing/runs_batch", tags=["test_runs_deletion"], retention_period="1 min")
309+
run.log_metrics({"x": i})
306310
client = svc.Client()
307-
assert len(client.delete_runs(run_data["folder"])) > 0
311+
assert len(client.delete_runs("/simvue_unit_testing/runs_batch")) > 0
308312

309313

310314
@pytest.mark.dependency

0 commit comments

Comments
 (0)