fix: 코드래빗 리뷰사항 적용

* refactor: 채널 생성 로직 중복 제거

* fix: 사용하지 않는 NewsStatus 제거

* fix: MentorMyPageServiceTest 에서 siteUserId 를 mentorId 처럼 사용하는 문제 수정

Author: sukangpunch

src/main/java/com/example/solidconnection/mentor/service/MentorMyPageService.java

@@ -70,11 +70,7 @@ public void updateMentorMyPage(long siteUserId, MentorMyPageUpdateRequest reques
     }
 
     private void updateChannel(List<ChannelRequest> channelRequests, Mentor mentor) {
-        int sequence = CHANNEL_SEQUENCE_START_NUMBER;
-        List<Channel> newChannels = new ArrayList<>();
-        for (ChannelRequest request : channelRequests) {
-            newChannels.add(new Channel(sequence++, request.type(), request.url()));
-        }
+        List<Channel> newChannels = buildChannels(channelRequests);
         mentor.updateChannels(newChannels);
     }
 
@@ -114,11 +110,16 @@ private void validateChannelRegistrationLimit(List<ChannelRequest> channelReques
     }
 
     private void createChannels(List<ChannelRequest> channelRequests, Mentor mentor) {
+        List<Channel> newChannels = buildChannels(channelRequests);
+        mentor.createChannels(newChannels);
+    }
+
+    private List<Channel> buildChannels(List<ChannelRequest> channelRequests) {
         int sequence = CHANNEL_SEQUENCE_START_NUMBER;
         List<Channel> newChannels = new ArrayList<>();
         for (ChannelRequest request : channelRequests) {
             newChannels.add(new Channel(sequence++, request.type(), request.url()));
         }
-        mentor.createChannels(newChannels);
+        return newChannels;
     }
 }

src/main/java/com/example/solidconnection/news/domain/NewsStatus.java

@@ -193,7 +193,7 @@ class 멘토의_마이페이지를_생성한다 {
             mentorMyPageService.createMentorMyPage(tempMentorUser.getId(), request);
 
             // then
-            Mentor createTempMentor = mentorRepository.findById(tempMentorUser.getId()).get();
+            Mentor createTempMentor = mentorRepository.findBySiteUserId(tempMentorUser.getId()).get();
             assertAll(
                     () -> assertThat(createTempMentor.getIntroduction()).isEqualTo(introduction),
                     () -> assertThat(createTempMentor.getPassTip()).isEqualTo(passTip),