Skip to content

Commit dc04ef6

Browse files
committed
refactor: 코드래빗 리뷰사항 반영
* test: contains 로 비교하던 검증 로직을 isEqualTo 로 수정 * test: preHandle 테스트 에서 result 값을 항상 검증
1 parent d346239 commit dc04ef6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/test/java/com/example/solidconnection/common/interceptor/ApiPerformanceInterceptorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ class 예외_발생_시 {
191191
.findFirst()
192192
.orElseThrow();
193193
assertAll(
194-
() -> assertThat(logEvent.getLevel().toString()).contains("INFO"),
194+
() -> assertThat(logEvent.getLevel().toString()).isEqualTo("INFO"),
195195
() -> assertThat(logEvent.getFormattedMessage()).contains("uri=/api/error"),
196196
() -> assertThat(logEvent.getFormattedMessage()).contains("method_type=GET"),
197197
() -> assertThat(logEvent.getFormattedMessage()).contains("status=500")

src/test/java/com/example/solidconnection/common/interceptor/RequestContextInterceptorTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ class PreHandle_메서드 {
6262
when(request.getAttribute(BEST_MATCHING_PATTERN_ATTRIBUTE)).thenReturn(null);
6363

6464
// when
65-
interceptor.preHandle(request, response, handler);
65+
boolean result = interceptor.preHandle(request, response, handler);
6666

6767
// then
68+
assertThat(result).isTrue();
69+
6870
RequestContext context = RequestContextHolder.getContext();
6971
assertThat(context.getBestMatchPath()).isNull();
7072
}

0 commit comments

Comments
 (0)