CR fixes

Author: xJac0b

lib/src/lints/avoid_using_api/avoid_using_api_linter.dart

@@ -328,7 +328,7 @@ class AvoidUsingApiLinter {
         return;
       }
 
-      if (!_hasNamedParameter(node.argumentList, namedParameter)) {
+      if (!_containsNamedParameter(node.argumentList, namedParameter)) {
         return;
       }
 
@@ -346,10 +346,9 @@ class AvoidUsingApiLinter {
     });
 
     context.registry.addInstanceCreationExpression((node) {
-      final String? expectedConstructorName;
-      if (identifier == defaultConstructorIdentifier) {
-        expectedConstructorName = null;
-      } else {
+      String? expectedConstructorName;
+
+      if (identifier != defaultConstructorIdentifier) {
         expectedConstructorName = identifier;
       }
 
@@ -362,7 +361,7 @@ class AvoidUsingApiLinter {
         return;
       }
 
-      if (!_hasNamedParameter(node.argumentList, namedParameter)) {
+      if (!_containsNamedParameter(node.argumentList, namedParameter)) {
         return;
       }
 
@@ -376,7 +375,10 @@ class AvoidUsingApiLinter {
     });
   }
 
-  bool _hasNamedParameter(ArgumentList argumentList, String namedParameter) =>
+  bool _containsNamedParameter(
+    ArgumentList argumentList,
+    String namedParameter,
+  ) =>
       argumentList.arguments.any(
         (arg) =>
             arg is NamedExpression && arg.name.label.name == namedParameter,

lint_test/avoid_using_api/external_source/lib/external_source.dart

@@ -4,35 +4,27 @@
 class BannedCodeUsage {
   final String test4 = 'Hello World';
 
-  BannedCodeUsage({this.parameter1, this.parameter2});
+  BannedCodeUsage();
 
-  String? parameter1;
-  String? parameter2;
-
-  factory BannedCodeUsage.test3({String? parameter1, String? parameter2}) {
-    return BannedCodeUsage(
-      parameter1: parameter1,
-      parameter2: parameter2,
-    );
+  factory BannedCodeUsage.test3() {
+    return BannedCodeUsage();
   }
 
-  BannedCodeUsage.test5({String? parameter1, String? parameter2});
-
-  void test({String? parameter1, String? parameter2}) {}
+  void test() {}
 
-  static String test2({String? parameter1, String? parameter2}) {
+  static String test2() {
     return 'Hello World';
   }
 }
 
 const test2 = 'Hello World';
 
-void test({String? parameter1}) {}
+void test() {}
 
 int banned = 5;
 
 extension BannedExtension on int {
-  int banned({String? parameter1, String? parameter2}) => this + 10;
+  int banned() => this + 10;
 
   int get bannedGetter => 10;
 }

lint_test/avoid_using_api/named_parameter_ban/analysis_options.yaml

@@ -8,32 +8,27 @@ custom_lint:
       severity: warning
       entries:
         - identifier: ()
-          named_parameter: parameter1
-          class_name: BannedCodeUsage
-          source: package:external_source
-          reason: "Use parameter2 instead"
-        - identifier: test3
-          named_parameter: parameter1
-          class_name: BannedCodeUsage
-          source: package:external_source
-          reason: "Use parameter2 instead"
-        - identifier: test5
-          named_parameter: parameter1
-          class_name: BannedCodeUsage
-          source: package:external_source
-          reason: "Use parameter2 instead"
-        - identifier: test2
-          named_parameter: parameter1
-          class_name: BannedCodeUsage
-          source: package:external_source
-          reason: "Use parameter2 instead"
-        - identifier: test
-          named_parameter: parameter1
-          class_name: BannedCodeUsage
-          source: package:external_source
-          reason: "Use parameter2 instead"
-        - identifier: banned
-          named_parameter: parameter1
-          class_name: BannedExtension
-          source: package:external_source
-          reason: "Use parameter2 instead"
+          named_parameter: badParameter
+          class_name: NamedParameterBan
+          source: package:named_parameter_ban
+          reason: "Use goodParameter instead"
+        - identifier: namedConstructor
+          named_parameter: badParameter
+          class_name: NamedParameterBan
+          source: package:named_parameter_ban
+          reason: "Use goodParameter instead"
+        - identifier: staticMethod
+          named_parameter: badParameter
+          class_name: NamedParameterBan
+          source: package:named_parameter_ban
+          reason: "Use goodParameter instead"
+        - identifier: method
+          named_parameter: badParameter
+          class_name: NamedParameterBan
+          source: package:named_parameter_ban
+          reason: "Use goodParameter instead"
+        - identifier: extensionMethod
+          named_parameter: badParameter
+          class_name: NamedParameterBanExtension
+          source: package:named_parameter_ban
+          reason: "Use goodParameter instead"

lint_test/avoid_using_api/named_parameter_ban/lib/named_parameter_ban.dart

@@ -0,0 +1,16 @@
+class NamedParameterBan {
+  NamedParameterBan({this.badParameter, this.goodParameter});
+
+  String? badParameter;
+  String? goodParameter;
+
+  NamedParameterBan.namedConstructor(
+      {String? badParameter, String? goodParameter}) {}
+
+  void method({String? badParameter, String? goodParameter}) {}
+  static void staticMethod({String? badParameter, String? goodParameter}) {}
+}
+
+extension NamedParameterBanExtension on int {
+  String extensionMethod({String? badParameter, String? goodParameter}) => '';
+}

lint_test/avoid_using_api/named_parameter_ban/lib/named_parameter_ban_test.dart

@@ -1,28 +1,26 @@
-// ignore_for_file: unused_local_variable
-
-import 'package:external_source/external_source.dart';
+import 'package:named_parameter_ban/named_parameter_ban.dart';
 
 void testingBannedCodeLint() async {
   // expect_lint: avoid_using_api
-  final bannedCodeUsage = BannedCodeUsage(parameter1: '');
-
-  // expect_lint: avoid_using_api
-  final test3 = BannedCodeUsage.test3(parameter1: '');
+  NamedParameterBan(badParameter: '');
+  NamedParameterBan(goodParameter: '');
 
   // expect_lint: avoid_using_api
-  final test5 = BannedCodeUsage.test5(parameter1: '');
+  NamedParameterBan.namedConstructor(badParameter: '');
+  NamedParameterBan.namedConstructor(goodParameter: '');
 
   // expect_lint: avoid_using_api
-  BannedCodeUsage.test2(
-    parameter1: 'test',
+  NamedParameterBan.staticMethod(
+    badParameter: 'test',
   );
+  NamedParameterBan.staticMethod(goodParameter: '');
 
-  final obj = BannedCodeUsage();
+  final obj = NamedParameterBan();
   // expect_lint: avoid_using_api
-  obj.test(parameter1: '');
-
-  test(parameter1: '');
+  obj.method(badParameter: '');
+  obj.method(goodParameter: '');
 
   // expect_lint: avoid_using_api
-  2.banned(parameter1: '');
+  0.extensionMethod(badParameter: '');
+  0.extensionMethod(goodParameter: '');
 }