Skip to content

Clean up GCP plugin logging strings and adjust mypy settings for current plugin constraints #2335

@drwicid

Description

@drwicid

Description

Summary

The GCP plugin branch includes a small cleanup commit that is not part of a behavior fix. It standardizes embedded quote usage in log messages and relaxes a few mypy error codes in the plugin tox configuration to reflect current typing limits.

This issue, and warnings were flagged while attempting to run tox testing of PR #2334

Impact

  • Removes inconsistent quoting in log output paths.
  • Keeps the plugin import and static-analysis path cleaner.
  • Reduces friction from mypy failures that are not currently actionable in the plugin.

Affected Files And Changes

  • plugins/gcp/fix_plugin_gcp/resources/base.py
    • Normalize the embedded 'global' fallback quoting in the collection log message.
  • plugins/gcp/fix_plugin_gcp/resources/filestore.py
    • Normalize the embedded 'global' fallback quoting in the snapshot collection log message.
  • plugins/gcp/fix_plugin_gcp/resources/firestore.py
    • Normalize the embedded 'global' fallback quoting in the document collection log message.
  • plugins/gcp/tox.ini
    • Expand the mypy command with targeted flags for existing plugin typing gaps.

Expected Outcome

  • Log message formatting stays consistent across GCP resource modules.
  • The plugin's mypy job reflects the current codebase constraints instead of failing on known non-actionable cases.

Version

v3.4.0

Environment

Docker

Steps to Reproduce

No response

Logs

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions