add mustParseURL helper to login tests

Author: peterguy

cmd/src/login_test.go

@@ -16,6 +16,15 @@ import (
 	"github.com/sourcegraph/src-cli/internal/oauth"
 )
 
+func mustParseURL(t *testing.T, raw string) *url.URL {
+	t.Helper()
+	u, err := url.Parse(raw)
+	if err != nil {
+		t.Fatalf("failed to parse URL %q: %v", raw, err)
+	}
+	return u
+}
+
 func TestLogin(t *testing.T) {
 	check := func(t *testing.T, cfg *config, endpointArgURL *url.URL) (output string, err error) {
 		t.Helper()
@@ -72,7 +81,7 @@ func TestLogin(t *testing.T) {
 		}))
 		defer s.Close()
 
-		u, _ := url.ParseRequestURI(s.URL)
+		u := mustParseURL(t, s.URL)
 		out, err := check(t, &config{endpointURL: u, accessToken: "x"}, u)
 		if err != cmderrors.ExitCode1 {
 			t.Fatal(err)
@@ -90,7 +99,7 @@ func TestLogin(t *testing.T) {
 		}))
 		defer s.Close()
 
-		u, _ := url.ParseRequestURI(s.URL)
+		u := mustParseURL(t, s.URL)
 		out, err := check(t, &config{endpointURL: u, accessToken: "x"}, u)
 		if err != nil {
 			t.Fatal(err)
@@ -173,17 +182,9 @@ func (f fakeOAuthClient) Refresh(context.Context, *oauth.Token) (*oauth.TokenRes
 }
 
 func TestSelectLoginFlow(t *testing.T) {
-	mustParseURL := func(s string) *url.URL {
-		u, err := url.Parse(s)
-		if err != nil {
-			t.Fatal(err)
-		}
-		return u
-	}
-
 	t.Run("uses oauth flow when no access token is configured", func(t *testing.T) {
 		params := loginParams{
-			cfg: &config{endpointURL: mustParseURL("https://example.com")},
+			cfg: &config{endpointURL: mustParseURL(t, "https://example.com")},
 		}
 
 		if got, _ := selectLoginFlow(params); got != loginFlowOAuth {
@@ -193,7 +194,7 @@ func TestSelectLoginFlow(t *testing.T) {
 
 	t.Run("uses validation flow when auth exists for the selected endpoint", func(t *testing.T) {
 		params := loginParams{
-			cfg: &config{endpointURL: mustParseURL("https://example.com"), accessToken: "x"},
+			cfg: &config{endpointURL: mustParseURL(t, "https://example.com"), accessToken: "x"},
 		}
 
 		if got, _ := selectLoginFlow(params); got != loginFlowValidate {