diff --git a/src/extension/alterschema/CMakeLists.txt b/src/extension/alterschema/CMakeLists.txt index ee43cbbab..3d3c88df9 100644 --- a/src/extension/alterschema/CMakeLists.txt +++ b/src/extension/alterschema/CMakeLists.txt @@ -24,6 +24,7 @@ sourcemeta_library(NAMESPACE sourcemeta PROJECT core NAME alterschema common/anyof_false_simplify.h common/anyof_remove_false_schemas.h common/anyof_true_simplify.h + common/const_in_enum.h common/const_with_type.h common/orphan_definitions.h common/content_media_type_without_encoding.h @@ -71,6 +72,7 @@ sourcemeta_library(NAMESPACE sourcemeta PROJECT core NAME alterschema # Linter linter/comment_trim.h + linter/const_not_in_enum.h linter/content_schema_default.h linter/definitions_to_defs.h linter/dependencies_default.h diff --git a/src/extension/alterschema/alterschema.cc b/src/extension/alterschema/alterschema.cc index 131b20c7b..be4bf3ba9 100644 --- a/src/extension/alterschema/alterschema.cc +++ b/src/extension/alterschema/alterschema.cc @@ -52,6 +52,7 @@ inline auto APPLIES_TO_POINTERS(std::vector &&keywords) #include "common/anyof_false_simplify.h" #include "common/anyof_remove_false_schemas.h" #include "common/anyof_true_simplify.h" +#include "common/const_in_enum.h" #include "common/const_with_type.h" #include "common/content_media_type_without_encoding.h" #include "common/content_schema_without_media_type.h" @@ -99,6 +100,7 @@ inline auto APPLIES_TO_POINTERS(std::vector &&keywords) // Linter #include "linter/comment_trim.h" +#include "linter/const_not_in_enum.h" #include "linter/content_schema_default.h" #include "linter/definitions_to_defs.h" #include "linter/dependencies_default.h" @@ -176,6 +178,7 @@ auto add(SchemaTransformer &bundle, const AlterSchemaMode mode) -> void { bundle.add(); bundle.add(); bundle.add(); + bundle.add(); bundle.add(); bundle.add(); bundle.add(); @@ -207,6 +210,7 @@ auto add(SchemaTransformer &bundle, const AlterSchemaMode mode) -> void { if (mode == AlterSchemaMode::Linter) { bundle.add(); + bundle.add(); bundle.add(); bundle.add(); bundle.add(); diff --git a/src/extension/alterschema/common/const_in_enum.h b/src/extension/alterschema/common/const_in_enum.h new file mode 100644 index 000000000..0161d8dc0 --- /dev/null +++ b/src/extension/alterschema/common/const_in_enum.h @@ -0,0 +1,34 @@ +class ConstInEnum final : public SchemaTransformRule { +public: + using mutates = std::true_type; + using reframe_after_transform = std::true_type; + ConstInEnum() + : SchemaTransformRule{ + "const_in_enum", + "If the `const` and `enum` keyword overlap, then `enum` is " + "redundant and can be removed"} {}; + + [[nodiscard]] auto + condition(const sourcemeta::core::JSON &schema, + const sourcemeta::core::JSON &, + const sourcemeta::core::Vocabularies &vocabularies, + const sourcemeta::core::SchemaFrame &, + const sourcemeta::core::SchemaFrame::Location &, + const sourcemeta::core::SchemaWalker &, + const sourcemeta::core::SchemaResolver &) const + -> sourcemeta::core::SchemaTransformRule::Result override { + ONLY_CONTINUE_IF(vocabularies.contains_any( + {Vocabularies::Known::JSON_Schema_2020_12_Validation, + Vocabularies::Known::JSON_Schema_2019_09_Validation, + Vocabularies::Known::JSON_Schema_Draft_7, + Vocabularies::Known::JSON_Schema_Draft_6}) && + schema.is_object() && schema.defines("const") && + schema.defines("enum") && schema.at("enum").is_array() && + schema.at("enum").contains(schema.at("const"))); + return APPLIES_TO_KEYWORDS("const", "enum"); + } + + auto transform(JSON &schema, const Result &) const -> void override { + schema.erase("enum"); + } +}; diff --git a/src/extension/alterschema/linter/const_not_in_enum.h b/src/extension/alterschema/linter/const_not_in_enum.h new file mode 100644 index 000000000..4aff28f9e --- /dev/null +++ b/src/extension/alterschema/linter/const_not_in_enum.h @@ -0,0 +1,30 @@ +class ConstNotInEnum final : public SchemaTransformRule { +public: + using mutates = std::false_type; + using reframe_after_transform = std::false_type; + ConstNotInEnum() + : SchemaTransformRule{ + "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same time, " + "mainly when their values diverge"} {}; + + [[nodiscard]] auto + condition(const sourcemeta::core::JSON &schema, + const sourcemeta::core::JSON &, + const sourcemeta::core::Vocabularies &vocabularies, + const sourcemeta::core::SchemaFrame &, + const sourcemeta::core::SchemaFrame::Location &, + const sourcemeta::core::SchemaWalker &, + const sourcemeta::core::SchemaResolver &) const + -> sourcemeta::core::SchemaTransformRule::Result override { + ONLY_CONTINUE_IF(vocabularies.contains_any( + {Vocabularies::Known::JSON_Schema_2020_12_Validation, + Vocabularies::Known::JSON_Schema_2019_09_Validation, + Vocabularies::Known::JSON_Schema_Draft_7, + Vocabularies::Known::JSON_Schema_Draft_6}) && + schema.is_object() && schema.defines("const") && + schema.defines("enum") && schema.at("enum").is_array() && + !schema.at("enum").contains(schema.at("const"))); + return APPLIES_TO_KEYWORDS("const", "enum"); + } +}; diff --git a/test/alterschema/alterschema_lint_2019_09_test.cc b/test/alterschema/alterschema_lint_2019_09_test.cc index b68b20641..81863c7da 100644 --- a/test/alterschema/alterschema_lint_2019_09_test.cc +++ b/test/alterschema/alterschema_lint_2019_09_test.cc @@ -4494,3 +4494,182 @@ TEST(AlterSchema_lint_2019_09, empty_object_as_true_1) { EXPECT_EQ(document, expected); } + +TEST(AlterSchema_lint_2019_09, const_in_enum_1) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2019_09, const_without_enum) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2019_09, enum_without_const) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2019_09, const_in_enum_4) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [1, 2, 3] + } + } + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1 + } + } + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2019_09, const_in_enum_edge_case_preserves_siblings) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2019_09, const_not_in_enum_1) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [2, 3] + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} + +TEST(AlterSchema_lint_2019_09, const_not_in_enum_2) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2019-09/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [2, 3] + } + } + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "/properties/foo", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} diff --git a/test/alterschema/alterschema_lint_2020_12_test.cc b/test/alterschema/alterschema_lint_2020_12_test.cc index ba496eff7..0d99b32c9 100644 --- a/test/alterschema/alterschema_lint_2020_12_test.cc +++ b/test/alterschema/alterschema_lint_2020_12_test.cc @@ -9664,3 +9664,182 @@ TEST(AlterSchema_lint_2020_12, object_oneof_required_not_required_6) { "can be elevated", true); } + +TEST(AlterSchema_lint_2020_12, const_in_enum_1) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2020_12, const_without_enum) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2020_12, enum_without_const) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2020_12, const_in_enum_4) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [1, 2, 3] + } + } + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1 + } + } + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2020_12, const_in_enum_edge_case_preserves_siblings) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_2020_12, const_not_in_enum_1) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [2, 3] + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} + +TEST(AlterSchema_lint_2020_12, const_not_in_enum_2) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "https://json-schema.org/draft/2020-12/schema", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [2, 3] + } + } + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "/properties/foo", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} diff --git a/test/alterschema/alterschema_lint_draft6_test.cc b/test/alterschema/alterschema_lint_draft6_test.cc index 6193d80bb..b83ee9909 100644 --- a/test/alterschema/alterschema_lint_draft6_test.cc +++ b/test/alterschema/alterschema_lint_draft6_test.cc @@ -2929,3 +2929,182 @@ TEST(AlterSchema_lint_draft6, empty_object_as_true_1) { EXPECT_EQ(document, expected); } + +TEST(AlterSchema_lint_draft6, const_in_enum_1) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft6, const_without_enum) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft6, enum_without_const) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft6, const_in_enum_4) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [1, 2, 3] + } + } + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1 + } + } + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft6, const_in_enum_edge_case_preserves_siblings) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft6, const_not_in_enum_1) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [2, 3] + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} + +TEST(AlterSchema_lint_draft6, const_not_in_enum_2) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-06/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [2, 3] + } + } + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "/properties/foo", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} diff --git a/test/alterschema/alterschema_lint_draft7_test.cc b/test/alterschema/alterschema_lint_draft7_test.cc index 14b0734c2..434573a5f 100644 --- a/test/alterschema/alterschema_lint_draft7_test.cc +++ b/test/alterschema/alterschema_lint_draft7_test.cc @@ -3507,3 +3507,182 @@ TEST(AlterSchema_lint_draft7, "illustrate the expected data", false); } + +TEST(AlterSchema_lint_draft7, const_in_enum_1) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft7, const_without_enum) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": "foo" + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft7, enum_without_const) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "enum": [1, 2, 3] + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft7, const_in_enum_4) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [1, 2, 3] + } + } + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1 + } + } + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft7, const_in_enum_edge_case_preserves_siblings) { + sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1, + "enum": [1, 2, 3] + })JSON"); + + LINT_AND_FIX(document, result, traces); + + EXPECT_TRUE(result.first); + + const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "$id": "https://example.com/schemas/my-schema", + "description": "Edge case schema", + "examples": [{}], + "title": "Edge Case Schema", + "x-custom-annotation": "should not be deleted", + "const": 1 + })JSON"); + + EXPECT_EQ(document, expected); +} + +TEST(AlterSchema_lint_draft7, const_not_in_enum_1) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [1], + "const": 1, + "enum": [2, 3] + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +} + +TEST(AlterSchema_lint_draft7, const_not_in_enum_2) { + const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({ + "$schema": "http://json-schema.org/draft-07/schema#", + "title": "Test", + "description": "Test description", + "examples": [{}], + "properties": { + "foo": { + "const": 1, + "enum": [2, 3] + } + } + })JSON"); + + LINT_WITHOUT_FIX(document, result, traces); + + EXPECT_FALSE(result.first); + EXPECT_EQ(traces.size(), 1); + EXPECT_LINT_TRACE(traces, 0, "/properties/foo", "const_not_in_enum", + "Do not set the `const` and `enum` keyword at the same " + "time, mainly when their values diverge", + false); +}