Skip to content

Commit db91902

Browse files
authored
Log HTTP responses with correct severity and include status reason (#1251)
* Log non-2xx HTTP responses in request completion log * fix log message
1 parent e976252 commit db91902

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/webserver/http.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,13 +371,17 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder {
371371
DefaultRootSpanBuilder::on_request_end(span, outcome);
372372

373373
// Emit a single log event per completed request so it appears in logs.
374-
// Error responses (4xx/5xx) are already logged by our error handlers.
375374
let _enter = span_ref.enter();
376375
if let Ok(response) = outcome {
377376
let status = response.response().status();
378-
if status.is_success() || status.is_redirection() {
379-
log::info!("{}", status.canonical_reason().unwrap_or("ok"));
380-
}
377+
let level = if status.is_server_error() {
378+
log::Level::Error
379+
} else if status.is_client_error() {
380+
log::Level::Warn
381+
} else {
382+
log::Level::Info
383+
};
384+
log::log!(level, "{status}");
381385
}
382386
}
383387
}

0 commit comments

Comments
 (0)