Skip to content

Commit 9aefeac

Browse files
committed
chore: reintroduce comments for Assessments
1 parent d2114b8 commit 9aefeac

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

frontend/src/core/observations/ObservationAssessment.tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
useRefresh,
1313
} from "react-admin";
1414

15+
import MarkdownEdit from "../../commons/custom_fields/MarkdownEdit";
1516
import SmallButton from "../../commons/custom_fields/SmallButton";
1617
import { ToolbarCancelSave } from "../../commons/custom_fields/ToolbarCancelSave";
1718
import { validate_after_today, validate_required } from "../../commons/custom_validators";
@@ -35,6 +36,7 @@ import {
3536
const ObservationAssessment = () => {
3637
const observation = useRecordContext();
3738
const dialogRef = useRef<HTMLDivElement>(null);
39+
const [comment, setComment] = useState("");
3840
const [open, setOpen] = useState(false);
3941
const [status, setStatus] = useState(observation?.current_status);
4042
const justificationEnabled = justificationIsEnabledForStatus(status);
@@ -48,6 +50,7 @@ const ObservationAssessment = () => {
4850
status: data.current_status,
4951
vex_justification: justificationEnabled ? data.current_vex_justification : "",
5052
vex_remediations: remediationsEnabled ? data.current_vex_remediations : "",
53+
comment: comment,
5154
risk_acceptance_expiry_date: data.risk_acceptance_expiry_date,
5255
};
5356

@@ -143,6 +146,13 @@ const ObservationAssessment = () => {
143146
)
144147
}
145148
</FormDataConsumer>
149+
<MarkdownEdit
150+
initialValue=""
151+
setValue={setComment}
152+
label="Comment"
153+
overlayContainer={dialogRef.current ?? null}
154+
maxLength={4096}
155+
/>
146156
</SimpleForm>
147157
</DialogContent>
148158
</Dialog>

frontend/src/core/observations/ObservationBulkAssessment.tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
useUnselectAll,
1414
} from "react-admin";
1515

16+
import MarkdownEdit from "../../commons/custom_fields/MarkdownEdit";
1617
import SmallButton from "../../commons/custom_fields/SmallButton";
1718
import { ToolbarCancelSave } from "../../commons/custom_fields/ToolbarCancelSave";
1819
import { validate_after_today } from "../../commons/custom_validators";
@@ -42,6 +43,7 @@ type ObservationBulkAssessmentButtonProps = {
4243

4344
const ObservationBulkAssessment = ({ product, storeKey }: ObservationBulkAssessmentButtonProps) => {
4445
const dialogRef = useRef<HTMLDivElement>(null);
46+
const [comment, setComment] = useState("");
4547
const [open, setOpen] = useState(false);
4648
const [status, setStatus] = useState(OBSERVATION_STATUS_OPEN);
4749
const justificationEnabled = justificationIsEnabledForStatus(status);
@@ -63,6 +65,7 @@ const ObservationBulkAssessment = ({ product, storeKey }: ObservationBulkAssessm
6365
const assessment_data = {
6466
severity: data.current_severity,
6567
status: data.current_status,
68+
comment: comment,
6669
vex_justification: justificationEnabled ? data.current_vex_justification : "",
6770
vex_remediations: remediationsEnabled ? data.current_vex_remediations : "",
6871
observations: selectedIds,
@@ -168,6 +171,13 @@ const ObservationBulkAssessment = ({ product, storeKey }: ObservationBulkAssessm
168171
)
169172
}
170173
</FormDataConsumer>
174+
<MarkdownEdit
175+
initialValue=""
176+
setValue={setComment}
177+
label="Comment"
178+
overlayContainer={dialogRef.current ?? null}
179+
maxLength={4096}
180+
/>
171181
</SimpleForm>
172182
</DialogContent>
173183
</Dialog>

0 commit comments

Comments
 (0)