Skip to content

Commit 9c12264

Browse files
committed
fix: don't end of notifications for observation_title for new observation
1 parent 7632a62 commit 9c12264

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

backend/application/core/services/observation_log.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ def create_observation_log( # pylint: disable=too-many-arguments
5454
Assessment_Status.ASSESSMENT_STATUS_REMOVED
5555
):
5656
send_observation_notification(observation)
57-
send_observation_title_notification(observation)
57+
send_observation_title_notification(
58+
observation, Observation_Log.objects.filter(observation=observation).count() == 1
59+
)
5860

5961
return observation_log
6062

backend/application/notifications/services/send_notifications_observation_title.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from typing import Optional
2+
13
from application.access_control.services.current_user import get_current_user
24
from application.commons.models import Settings
35
from application.commons.services.functions import get_base_url_frontend
@@ -15,7 +17,7 @@
1517
)
1618

1719

18-
def send_observation_title_notification(observation: Observation) -> None:
20+
def send_observation_title_notification(observation: Observation, observation_new: Optional[bool] = False) -> None:
1921
settings = Settings.load()
2022

2123
observation_title_notification_min_severity = settings.observation_title_notification_min_severity
@@ -89,7 +91,7 @@ def send_observation_title_notification(observation: Observation) -> None:
8991
observation_title_notified.status = observation.current_status
9092
observation_title_notified.priority = observation.current_priority
9193
observation_title_notified.save()
92-
else:
94+
elif not observation_new:
9395
try:
9496
observation_title_notified = Observation_Title_Notified.objects.get(title=observation.title)
9597
except Observation_Title_Notified.DoesNotExist:

0 commit comments

Comments
 (0)