fix(secrets-manager): include instance name in payload, as it is required

Author: s-inter

internal/cmd/secrets-manager/instance/update/update.go

@@ -75,6 +75,9 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 			if err != nil {
 				params.Printer.Debug(print.ErrorLevel, "get instance name: %v", err)
 				instanceLabel = model.InstanceId
+				if model.KmsKeyId != nil {
+					return fmt.Errorf("get instance name: %w", err)
+				}
 			}
 
 			prompt := fmt.Sprintf("Are you sure you want to update instance %q?", instanceLabel)
@@ -84,7 +87,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 			}
 
 			// Call API
-			req := buildRequest(ctx, model, apiClient)
+			req := buildRequest(ctx, model, instanceLabel, apiClient)
 			switch request := req.(type) {
 			case secretsmanager.ApiUpdateInstanceRequest:
 				err = request.Execute()
@@ -142,18 +145,19 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 	return &model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *secretsmanager.APIClient) interface{ Execute() error } {
+func buildRequest(ctx context.Context, model *inputModel, instanceName string, apiClient *secretsmanager.APIClient) interface{ Execute() error } {
 	if model.KmsKeyId != nil {
-		return buildUpdateInstanceRequest(ctx, model, apiClient)
+		return buildUpdateInstanceRequest(ctx, model, instanceName, apiClient)
 	}
 
 	return buildUpdateACLsRequest(ctx, model, apiClient)
 }
 
-func buildUpdateInstanceRequest(ctx context.Context, model *inputModel, apiClient *secretsmanager.APIClient) secretsmanager.ApiUpdateInstanceRequest {
+func buildUpdateInstanceRequest(ctx context.Context, model *inputModel, instanceName string, apiClient *secretsmanager.APIClient) secretsmanager.ApiUpdateInstanceRequest {
 	req := apiClient.UpdateInstance(ctx, model.ProjectId, model.InstanceId)
 
 	payload := secretsmanager.UpdateInstancePayload{
+		Name: &instanceName,
 		KmsKey: &secretsmanager.KmsKeyPayload{
 			KeyId:               model.KmsKeyId,
 			KeyRingId:           model.KmsKeyringId,

internal/cmd/secrets-manager/instance/update/update_test.go

@@ -32,6 +32,7 @@ var (
 )
 
 const (
+	testInstanceName           = "test-instance"
 	testKmsKeyId               = "key-id"
 	testKmsKeyringId           = "keyring-id"
 	testKmsKeyVersion          = int64(1)
@@ -90,6 +91,7 @@ func fixtureRequest(mods ...func(request *secretsmanager.ApiUpdateACLsRequest))
 func fixtureUpdateInstanceRequest(mods ...func(request *secretsmanager.ApiUpdateInstanceRequest)) secretsmanager.ApiUpdateInstanceRequest {
 	request := testClient.UpdateInstance(testCtx, testProjectId, testInstanceId)
 	request = request.UpdateInstancePayload(secretsmanager.UpdateInstancePayload{
+		Name: utils.Ptr(testInstanceName),
 		KmsKey: &secretsmanager.KmsKeyPayload{
 			KeyId:               utils.Ptr(testKmsKeyId),
 			KeyRingId:           utils.Ptr(testKmsKeyringId),
@@ -288,7 +290,7 @@ func TestBuildRequest(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.description, func(t *testing.T) {
-			request := buildRequest(testCtx, tt.model, testClient)
+			request := buildRequest(testCtx, tt.model, testInstanceName, testClient)
 			aclRequest, ok := request.(secretsmanager.ApiUpdateACLsRequest)
 			if !ok {
 				t.Fatalf("expected ACL update request, got %T", request)
@@ -314,7 +316,7 @@ func TestBuildRequestKms(t *testing.T) {
 		model.KmsServiceAccountEmail = utils.Ptr(testKmsServiceAccountEmail)
 	})
 
-	request := buildRequest(testCtx, model, testClient)
+	request := buildRequest(testCtx, model, testInstanceName, testClient)
 	updateRequest, ok := request.(secretsmanager.ApiUpdateInstanceRequest)
 	if !ok {
 		t.Fatalf("expected instance update request, got %T", request)