Skip to content

Commit 1fe22db

Browse files
feat(go) do not generate api_tests, delete template (#230)
The generated API-tests used zero initialized requests and responses. Thus not really testing anything interesting. For APIs with a one-of in the response, tests would fail since `{}` can be deserialized into each of the options.
1 parent 27bb66e commit 1fe22db

2 files changed

Lines changed: 1 addition & 137 deletions

File tree

languages/golang/templates/api_test.mustache

Lines changed: 0 additions & 132 deletions
This file was deleted.

scripts/generate-sdk/languages/go.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ generate_go_sdk() {
160160
--git-host "${GIT_HOST}" \
161161
--git-user-id "${GIT_USER_ID}" \
162162
--git-repo-id "${GIT_REPO_ID}" \
163-
--global-property apis,models,modelTests=true,modelDocs=false,apiDocs=false,supportingFiles \
163+
--global-property apis,models,modelTests=true,modelDocs=false,apiDocs=false,supportingFiles,apiTests=false \
164164
--additional-properties=isGoSubmodule=true,enumClassPrefix=true,generateInterfaces=true,$regional_api \
165165
--http-user-agent "stackit-sdk-go/${service}" \
166166
--reserved-words-mappings type=types \
@@ -182,10 +182,6 @@ generate_go_sdk() {
182182
fi
183183
fi
184184

185-
# Move tests to the service folder
186-
cp "${SERVICES_FOLDER}"/"${service}"/test/* "${SERVICES_FOLDER}/${service}"
187-
rm -r "${SERVICES_FOLDER}/${service}/test/"
188-
189185
# If the service has a wait package files, move them inside the service folder
190186
if [ -d "${sdk_services_backup_dir}/${service}/wait" ]; then
191187
echo "Found ${service} \"wait\" package"

0 commit comments

Comments
 (0)