hexagon support

[androm3da]

rust_arches() says // hexagon gets build errors; disable it for now -- what are the build errors encountered, @sunfishcode? I want to help address these in order to add hexagon support. How can I reproduce the problem?

[sunfishcode]

I suggest enabling it and seeing what happens.

[androm3da]

Ok -- and I guess sorry for a series of dumb questions here, but ....

I enable it like below and run cargo update && cd gen && cargo run --release? When I did that I didn't see any sign of errors. Are the build errors during generation or use of the defined syscalls? I tried cargo test in linux-raw-sys and it didn't seem to exercise the calls. Should I try building a test program that leverages linux-raw-sys to see the build errors, then?

diff --git a/gen/src/main.rs b/gen/src/main.rs
index 3e67b70..05c3aa5 100644
--- a/gen/src/main.rs
+++ b/gen/src/main.rs
@@ -290,7 +290,7 @@ fn rust_arches(linux_arch: &str) -> &[&str] {
         "avr32" => &["avr"],
         "csky" => &["csky"],
         // hexagon gets build errors; disable it for now
-        "hexagon" => &[],
+        "hexagon" => &["hexagon"],
         "loongarch" => &["loongarch64"],
         "mips" => &["mips", "mips64", "mips32r6", "mips64r6"],
         "powerpc" => &["powerpc", "powerpc64"],

[androm3da]

rust-lang/compiler-builtins#682 was intended to mitigate a source of link errors in the past, it could have been one of the contributors to why this was disabled, for example.

[sunfishcode]

I don't remember what the errors were. It could have been any number of things. If you enable it now, and it works, and you add a CI cargo check line similar to what's there for other targets, and it passes, then that's good enough.

[androm3da]

Ok, thanks. Hopefully #172 will be satisfactory.