refactor(database): replace generic exceptions with custom PrimaryKeyWasNotInitialized and PropertyWasNotARelation

Author: laylatichy

packages/database/src/Exceptions/PrimaryKeyWasNotInitialized.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Database\Exceptions;
+
+use Exception;
+
+final class PrimaryKeyWasNotInitialized extends Exception
+{
+    public function __construct(
+        public readonly string $model,
+    ) {
+        parent::__construct("Cannot query relations on `{$model}` without a primary key value.");
+    }
+}

packages/database/src/Exceptions/PropertyWasNotARelation.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Database\Exceptions;
+
+use Exception;
+
+final class PropertyWasNotARelation extends Exception
+{
+    public function __construct(
+        public readonly string $property,
+        public readonly string $model,
+    ) {
+        parent::__construct("Property `{$property}` is not a relation on `{$model}`.");
+    }
+}

packages/database/src/IsDatabaseModel.php

@@ -4,11 +4,12 @@
 
 namespace Tempest\Database;
 
-use InvalidArgumentException;
 use Tempest\Database\Builder\QueryBuilders\CountQueryBuilder;
 use Tempest\Database\Builder\QueryBuilders\InsertQueryBuilder;
 use Tempest\Database\Builder\QueryBuilders\QueryBuilder;
 use Tempest\Database\Builder\QueryBuilders\SelectQueryBuilder;
+use Tempest\Database\Exceptions\PrimaryKeyWasNotInitialized;
+use Tempest\Database\Exceptions\PropertyWasNotARelation;
 use Tempest\Database\Exceptions\RelationWasMissing;
 use Tempest\Database\Exceptions\ValueWasMissing;
 use Tempest\Reflection\PropertyReflector;
@@ -273,17 +274,13 @@ public function query(string $relation): QueryBuilder
         $model = inspect(model: $this);
 
         if (! $model->hasPrimaryKey() || ! $model->getPrimaryKeyProperty()->isInitialized(object: $this)) {
-            throw new InvalidArgumentException(
-                message: sprintf('Cannot query relations on %s without a primary key value.', $model->getName()),
-            );
+            throw new PrimaryKeyWasNotInitialized(model: $model->getName());
         }
 
         $resolved = $model->getRelation(name: $relation);
 
         if ($resolved === null) {
-            throw new InvalidArgumentException(
-                message: sprintf('Property "%s" is not a relation on %s.', $relation, $model->getName()),
-            );
+            throw new PropertyWasNotARelation(property: $relation, model: $model->getName());
         }
 
         return $resolved->query(

tests/Integration/Database/Builder/IsDatabaseModelTest.php

@@ -7,11 +7,12 @@
 use Carbon\Carbon;
 use DateTime as NativeDateTime;
 use DateTimeImmutable;
-use InvalidArgumentException;
 use Tempest\Database\BelongsTo;
 use Tempest\Database\Builder\QueryBuilders\QueryBuilder;
 use Tempest\Database\Builder\QueryBuilders\SelectQueryBuilder;
 use Tempest\Database\Exceptions\DeleteStatementWasInvalid;
+use Tempest\Database\Exceptions\PrimaryKeyWasNotInitialized;
+use Tempest\Database\Exceptions\PropertyWasNotARelation;
 use Tempest\Database\Exceptions\RelationWasMissing;
 use Tempest\Database\Exceptions\ValueWasMissing;
 use Tempest\Database\HasMany;
@@ -851,7 +852,7 @@ public function test_query_throws_for_nonexistent_property(): void
 
         $author = Author::create(name: 'Author', type: AuthorType::A);
 
-        $this->expectException(InvalidArgumentException::class);
+        $this->expectException(PropertyWasNotARelation::class);
 
         $author->query('nonexistent');
     }
@@ -860,7 +861,7 @@ public function test_query_throws_for_unsaved_model(): void
     {
         $author = new Author(name: 'Unsaved');
 
-        $this->expectException(InvalidArgumentException::class);
+        $this->expectException(PrimaryKeyWasNotInitialized::class);
 
         $author->query('books');
     }