ADK: Allow overriding summary for Agents without overriding the start to close timeout (#1370)

* Allow overriding summary for agents without overriding the start to close timeout

* Add test and change activity_options name

---------

Co-authored-by: Tim Conley <timothy.conley@temporal.io>
Co-authored-by: tconley1428 <tconley1428@gmail.com>

Author: drewhoskins-temporal

temporalio/contrib/google_adk_agents/README.md

@@ -71,13 +71,14 @@ Model calls are intercepted and executed as Temporal activities with configurabl
 **Agent (Workflow) Side:**
 ```python
 from temporalio.contrib.google_adk_agents import TemporalModel
+from temporalio.workflow import ActivityConfig
 from google.adk import Agent
 
 
 # Add to agent
 agent = Agent(
     name="test_agent",
-    model=TemporalModel("gemini-2.5-pro"), 
+    model=TemporalModel("gemini-2.5-pro", activity_config=ActivityConfig(summary="Researcher Agent")), 
 )
 ```
 

temporalio/contrib/google_adk_agents/_model.py

@@ -39,19 +39,21 @@ class TemporalModel(BaseLlm):
     """A Temporal-based LLM model that executes model invocations as activities."""
 
     def __init__(
-        self, model_name: str, activity_options: ActivityConfig | None = None
+        self, model_name: str, activity_config: ActivityConfig | None = None
     ) -> None:
         """Initialize the TemporalModel.
 
         Args:
             model_name: The name of the model to use.
-            activity_options: Configuration options for the activity execution.
+            activity_config: Configuration options for the activity execution.
         """
         super().__init__(model=model_name)
         self._model_name = model_name
-        self._activity_options = activity_options or ActivityConfig(
+        self._activity_config = ActivityConfig(
             start_to_close_timeout=timedelta(seconds=60)
         )
+        if activity_config:
+            self._activity_config.update(activity_config)
 
     async def generate_content_async(
         self, llm_request: LlmRequest, stream: bool = False
@@ -68,7 +70,7 @@ async def generate_content_async(
         responses = await workflow.execute_activity(
             invoke_model,
             args=[llm_request],
-            **self._activity_options,
+            **self._activity_config,
         )
         for response in responses:
             yield response

tests/contrib/google_adk_agents/test_google_adk_agents.py

@@ -52,6 +52,7 @@
 )
 from temporalio.contrib.opentelemetry import OpenTelemetryPlugin, create_tracer_provider
 from temporalio.worker import Worker
+from temporalio.workflow import ActivityConfig
 from tests.contrib.opentelemetry.test_opentelemetry import dump_spans
 
 logger = logging.getLogger(__name__)
@@ -128,21 +129,31 @@ async def run(self, topic: str, model_name: str) -> str | None:
         # Sub-agent: Researcher
         researcher = LlmAgent(
             name="researcher",
-            model=TemporalModel(model_name),
+            model=TemporalModel(
+                model_name, activity_config=ActivityConfig(summary="Researcher Agent")
+            ),
             instruction="You are a researcher. Find information about the topic.",
         )
 
         # Sub-agent: Writer
         writer = LlmAgent(
             name="writer",
-            model=TemporalModel(model_name),
+            model=TemporalModel(
+                model_name, activity_config=ActivityConfig(summary="Writer Agent")
+            ),
             instruction="You are a poet. Write a haiku based on the research.",
         )
 
         # Root Agent: Coordinator
         coordinator = LlmAgent(
             name="coordinator",
-            model=TemporalModel(model_name),
+            model=TemporalModel(
+                model_name,
+                activity_config=ActivityConfig(
+                    start_to_close_timeout=timedelta(seconds=30),
+                    summary="Coordinator Agent",
+                ),
+            ),
             instruction="You are a coordinator. Delegate to researcher then writer.",
             sub_agents=[researcher, writer],
         )
@@ -551,3 +562,8 @@ async def test_single_agent_telemetry(client: Client):
         "          StartActivity:invoke_model",
         "            RunActivity:invoke_model",
     ]
+
+
+async def test_unsetting_timeout():
+    model = TemporalModel("", ActivityConfig(start_to_close_timeout=None))
+    assert model._activity_config.get("start_to_close_timeout", None) is None