Skip to content

Commit 6d7ca41

Browse files
AlexMikhalevclaude
andcommitted
fix(ci): resolve three pre-existing CI failures
1. Add desktop/src-tauri to workspace exclude array -- fixes Tauri build error "current package believes it's in a workspace when it's not" (caused by incomplete workspace decoupling in 314f99f) 2. Update deny.toml: add RUSTSEC-2023-0071 (RSA Marvin Attack, no fix available) to ignore list, remove orphaned RUSTSEC-2024-0421, and update bytes 1.11.0 -> 1.11.1 to fix RUSTSEC-2026-0007 3. Fix JavaScript indentation in performance-benchmarking.yml -- const comment was outside if-block scope, causing immediate workflow validation failure on every trigger Co-Authored-By: Terraphim AI <noreply@anthropic.com>
1 parent 61dcd06 commit 6d7ca41

4 files changed

Lines changed: 30 additions & 30 deletions

File tree

.github/workflows/performance-benchmarking.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -189,18 +189,18 @@ jobs:
189189
const sloMatch = report.match(/SLO Compliance: (\d+\.?\d*)%/);
190190
const sloCompliance = sloMatch ? sloMatch[1] : 'N/A';
191191
192-
const comment = [
193-
"## 🚀 Performance Benchmark Results",
194-
"",
195-
`**SLO Compliance:** ${sloCompliance}%`,
196-
"",
197-
"### Key Findings:",
198-
report.includes('violations')
199-
? '⚠️ Some performance thresholds were not met'
200-
: 'All performance requirements satisfied',
201-
"",
202-
`[View full report](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})`,
203-
].join("\\n");
192+
const comment = [
193+
"## Performance Benchmark Results",
194+
"",
195+
`**SLO Compliance:** ${sloCompliance}%`,
196+
"",
197+
"### Key Findings:",
198+
report.includes('violations')
199+
? 'Some performance thresholds were not met'
200+
: 'All performance requirements satisfied',
201+
"",
202+
`[View full report](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})`,
203+
].join("\\n");
204204
205205
github.rest.issues.createComment({
206206
issue_number: context.issue.number,

Cargo.lock

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
[workspace]
33
resolver = "2"
44
members = ["crates/*", "terraphim_server", "terraphim_firecracker", "terraphim_ai_nodejs"]
5-
exclude = ["crates/terraphim_agent_application", "crates/terraphim_truthforge", "crates/terraphim_validation", "crates/terraphim_rlm", "crates/terraphim_automata_py"] # Experimental crates (RLM feature-gated); automata_py is a PyO3 extension module -- build with `maturin develop` instead of cargo
5+
exclude = ["crates/terraphim_agent_application", "crates/terraphim_truthforge", "crates/terraphim_validation", "crates/terraphim_rlm", "crates/terraphim_automata_py", "desktop/src-tauri"] # Experimental crates; automata_py needs `maturin develop`; desktop/src-tauri built separately via Tauri CLI
66
default-members = ["terraphim_server"]
77

88
[workspace.package]

deny.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ yanked = "warn"
1010

1111
# Ignore specific advisories
1212
ignore = [
13-
# idna vulnerability via trust-dns-proto (transitive dep from terraphim_rlm)
14-
# Will be fixed when migrating from trust-dns to hickory-dns
15-
# TODO: Track migration in GitHub issue
16-
"RUSTSEC-2024-0421",
13+
# RSA Marvin Attack - transitive dep via octocrab -> jsonwebtoken -> rsa
14+
# No safe upgrade available yet; RustCrypto team migrating to constant-time impl
15+
# TODO: Remove once octocrab updates to rsa with constant-time support
16+
"RUSTSEC-2023-0071",
1717
# atty unaligned read - transitive dep, only affects Windows with custom allocators
1818
"RUSTSEC-2021-0145",
1919
# atty unmaintained - used by terraphim_agent, should migrate to std::io::IsTerminal

0 commit comments

Comments
 (0)