Skip to content

Commit 4a40f90

Browse files
kv2019ilgirdwood
authored andcommitted
app: prj.conf: use trigger threshold of 1 as default
Set CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=1 as the default behaviour. Given most actions in the DSP FW happen every LL (msec) tick, having defer logic of upto 100msec in the logging subsystem is not really helpful. Logging thread should be preempted by higher priority threads in any case. This setting will cause the logger thread to be woken up (with a semaphore) every time a log entry is printed and no timer is used at all. The actual logging will not happen until logger thread gets to run, but the wakeup request is immediate. This setting works better with logging backends that have a limited internal buffer (like mtrace and Zephyr winconsole) that are commonly used with SOF targets. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent c3b8a95 commit 4a40f90

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

app/prj.conf

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@ CONFIG_LOG=y
2020
CONFIG_LOG_PRINTK=y
2121
# Log processing is offloaded to a low-priority thread.
2222
CONFIG_LOG_MODE_DEFERRED=y
23-
# Wake the low-priority log thread every 100ms and/or
24-
# if more than 5 messages are queued by the frontend.
25-
CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=5
26-
CONFIG_LOG_PROCESS_THREAD_SLEEP_MS=100
23+
# Wake the low-priority log thread every time new log
24+
# messages are available
25+
CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD=1
2726
# Frontend buffer must be large enough to cover all
2827
# typical bursts of log messages.
2928
CONFIG_LOG_BUFFER_SIZE=4096

0 commit comments

Comments
 (0)