Skip to content

Commit df8b5e7

Browse files
committed
cmake/zephyr: unify cmake rules for src/audio/eq-iir and eq-fir
Adding all source files in a single, giant zephyr/CMakeLists.txt is inconvenient and does not scale. Modify Zephyr rules to use definitions in src/audio/eq-iir and src/audio/eq-fir instead. Link: #8260 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent f052f97 commit df8b5e7

4 files changed

Lines changed: 53 additions & 38 deletions

File tree

src/audio/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ set(base_files
1414
if(NOT CONFIG_COMP_MODULE_SHARED_LIBRARY_BUILD)
1515
add_subdirectory(buffers)
1616
add_subdirectory(pipeline)
17+
if(CONFIG_COMP_FIR)
18+
add_subdirectory(eq_fir)
19+
endif()
20+
if(CONFIG_COMP_IIR)
21+
add_subdirectory(eq_iir)
22+
endif()
1723
if(CONFIG_COMP_SRC)
1824
add_subdirectory(src)
1925
endif()
@@ -47,12 +53,6 @@ if(NOT CONFIG_COMP_MODULE_SHARED_LIBRARY_BUILD)
4753
${base_files}
4854
)
4955

50-
if(CONFIG_COMP_FIR)
51-
add_subdirectory(eq_fir)
52-
endif()
53-
if(CONFIG_COMP_IIR)
54-
add_subdirectory(eq_iir)
55-
endif()
5656
if(CONFIG_COMP_DCBLOCK)
5757
add_subdirectory(dcblock)
5858
endif()

src/audio/eq_fir/CMakeLists.txt

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,29 @@
11
# SPDX-License-Identifier: BSD-3-Clause
22

3-
add_local_sources(sof eq_fir.c eq_fir_generic.c eq_fir_hifi2ep.c eq_fir_hifi3.c)
3+
set(base_files eq_fir.c eq_fir_generic.c eq_fir_hifi2ep.c eq_fir_hifi3.c)
4+
45
if(CONFIG_IPC_MAJOR_3)
5-
add_local_sources(sof eq_fir_ipc3.c)
6+
list(APPEND base_files eq_fir_ipc3.c)
67
elseif(CONFIG_IPC_MAJOR_4)
7-
add_local_sources(sof eq_fir_ipc4.c)
8+
list(APPEND base_files eq_fir_ipc4.c)
89
endif()
910

11+
is_zephyr(it_is)
12+
if(it_is) ### Zephyr ###
13+
14+
if(CONFIG_COMP_FIR STREQUAL "m")
15+
16+
add_subdirectory(llext ${PROJECT_BINARY_DIR}/eq_fir_llext)
17+
add_dependencies(app eq_fir)
18+
19+
else()
20+
21+
zephyr_library_sources(${base_files})
22+
23+
endif()
24+
25+
else() ### XTOS ###
26+
27+
add_local_sources(sof ${base_files})
28+
29+
endif()

src/audio/eq_iir/CMakeLists.txt

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,29 @@
11
# SPDX-License-Identifier: BSD-3-Clause
22

3-
add_local_sources(sof eq_iir.c eq_iir_generic.c)
3+
set(base_files eq_iir.c eq_iir_generic.c)
4+
45
if(CONFIG_IPC_MAJOR_3)
5-
add_local_sources(sof eq_iir_ipc3.c)
6+
list(APPEND base_files eq_iir_ipc3.c)
67
elseif(CONFIG_IPC_MAJOR_4)
7-
add_local_sources(sof eq_iir_ipc4.c)
8+
list(APPEND base_files eq_iir_ipc4.c)
9+
endif()
10+
11+
is_zephyr(it_is)
12+
if(it_is) ### Zephyr ###
13+
14+
if(CONFIG_COMP_FIR STREQUAL "m")
15+
16+
add_subdirectory(llext ${PROJECT_BINARY_DIR}/eq_iir_llext)
17+
add_dependencies(app eq_iir)
18+
19+
else()
20+
21+
zephyr_library_sources(${base_files})
22+
23+
endif()
24+
25+
else() ### XTOS ###
26+
27+
add_local_sources(sof ${base_files})
28+
829
endif()

zephyr/CMakeLists.txt

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -506,32 +506,6 @@ elseif(CONFIG_IPC_MAJOR_4)
506506
set(ipc_suffix ipc4)
507507
endif()
508508

509-
if(CONFIG_COMP_FIR STREQUAL "m")
510-
add_subdirectory(${SOF_AUDIO_PATH}/eq_fir/llext
511-
${PROJECT_BINARY_DIR}/eq_fir_llext)
512-
add_dependencies(app eq_fir)
513-
elseif(CONFIG_COMP_FIR)
514-
zephyr_library_sources(
515-
${SOF_AUDIO_PATH}/eq_fir/eq_fir_hifi3.c
516-
${SOF_AUDIO_PATH}/eq_fir/eq_fir_hifi2ep.c
517-
${SOF_AUDIO_PATH}/eq_fir/eq_fir_generic.c
518-
${SOF_AUDIO_PATH}/eq_fir/eq_fir.c
519-
${SOF_AUDIO_PATH}/eq_fir/eq_fir_${ipc_suffix}.c
520-
)
521-
endif()
522-
523-
if(CONFIG_COMP_IIR STREQUAL "m")
524-
add_subdirectory(${SOF_AUDIO_PATH}/eq_iir/llext
525-
${PROJECT_BINARY_DIR}/eq_iir_llext)
526-
add_dependencies(app eq_iir)
527-
elseif(CONFIG_COMP_IIR)
528-
zephyr_library_sources(
529-
${SOF_AUDIO_PATH}/eq_iir/eq_iir.c
530-
${SOF_AUDIO_PATH}/eq_iir/eq_iir_${ipc_suffix}.c
531-
${SOF_AUDIO_PATH}/eq_iir/eq_iir_generic.c
532-
)
533-
endif()
534-
535509
if(CONFIG_COMP_ASRC STREQUAL "m")
536510
add_subdirectory(${SOF_AUDIO_PATH}/asrc/llext
537511
${PROJECT_BINARY_DIR}/asrc_llext)

0 commit comments

Comments
 (0)