fix: corrected routing issues

Author: thorsten

phpmyfaq/src/phpMyFAQ/Controller/Api/AbstractApiController.php

@@ -79,12 +79,12 @@ protected function getPaginationRequest(
 
     /**
      * Parses sorting parameters from the request
-     *
      * Validates sort field against whitelist to prevent SQL injection.
      *
-     * @param array $allowedFields Whitelist of allowed sort fields
+     * @param Request     $request
+     * @param array       $allowedFields Whitelist of allowed sort fields
      * @param string|null $defaultField Default sort field if none specified
-     * @param string $defaultOrder Default sort order (asc or desc)
+     * @param string      $defaultOrder Default sort order (asc or desc)
      * @return SortRequest
      */
     protected function getSortRequest(

phpmyfaq/src/phpMyFAQ/Controller/Api/FaqController.php

@@ -114,7 +114,7 @@ enum: ['id', 'datum', 'header', 'author_name'],
             ],
         ]),
     )]
-    #[Route('/api/v4.0/news', name: 'api.news.list', methods: ['GET'])]
+    #[Route(path: 'v4.0/news', name: 'api.news.list', methods: ['GET'])]
     public function list(Request $request): JsonResponse
     {
         // Get pagination and sorting parameters

phpmyfaq/src/phpMyFAQ/Controller/Api/NewsController.php

@@ -111,7 +111,7 @@ public function __construct(
             ],
         ],
     ]))]
-    #[Route('/api/v4.0/tags', name: 'api.tags.list', methods: ['GET'])]
+    #[Route(path: 'v4.0/tags', name: 'api.tags.list', methods: ['GET'])]
     public function list(?Request $request = null): JsonResponse
     {
         $request ??= Request::createFromGlobals();

phpmyfaq/src/phpMyFAQ/Controller/Api/TagController.php

@@ -1641,8 +1641,13 @@ public function getStickyFaqsData(): array
                 fcr.category_id AS category_id,
                 fv.visits AS visits
             FROM
-                %sfaqvisits fv,
                 %sfaqdata fd
+            LEFT JOIN
+                %sfaqvisits fv
+            ON
+                fd.id = fv.id
+            AND
+                fd.lang = fv.lang
             LEFT JOIN
                 %sfaqcategoryrelations fcr
             ON
@@ -1663,10 +1668,6 @@ public function getStickyFaqsData(): array
                 fd.active = 'yes'
             AND 
                 fd.sticky = 1
-            AND
-                fd.id = fv.id
-            AND 
-                fd.lang = fv.lang
             %s
             GROUP BY
                 fd.id, fd.lang, fd.thema, fcr.category_id, fv.visits

phpmyfaq/src/phpMyFAQ/Faq.php

@@ -749,6 +749,7 @@
         service('phpmyfaq.tags'),
         service('phpmyfaq.faq.statistics'),
         service('phpmyfaq.faq.metadata'),
+        service('phpmyfaq.language'),
     ]);
     $services->set(ApiGlossaryController::class, ApiGlossaryController::class)->args([
         service('phpmyfaq.glossary'),