[params] 100% coverage

[state] useValueState

Author: jamesgpearce

coverage.json

@@ -1 +1 @@
-{"tests":7244,"assertions":32227,"lines":{"total":2401,"covered":2400,"skipped":0,"pct":99.95},"statements":{"total":2598,"covered":2597,"skipped":0,"pct":99.96},"functions":{"total":1041,"covered":1040,"skipped":0,"pct":99.9},"branches":{"total":908,"covered":906,"skipped":0,"pct":99.77},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}
+{"tests":7250,"assertions":32247,"lines":{"total":2401,"covered":2401,"skipped":0,"pct":100},"statements":{"total":2598,"covered":2598,"skipped":0,"pct":100},"functions":{"total":1041,"covered":1041,"skipped":0,"pct":100},"branches":{"total":908,"covered":908,"skipped":0,"pct":100},"branchesTrue":{"total":0,"covered":0,"skipped":0,"pct":100}}

test/unit/core/other/queries.test.ts

@@ -5042,6 +5042,124 @@ describe('Parameterized', () => {
 
       expect(queries.getResultTable('q1')).toEqual({r1: {c1: 'a', c2: 'odd'}});
     });
+
+    test('changes param from string to array and back', () => {
+      queries.setQueryDefinition(
+        'q1',
+        't1',
+        ({select, where, param}) => {
+          select('c1');
+          where((getTableCell) => {
+            const p = param('p1');
+            return Array.isArray(p)
+              ? (p as string[]).includes(getTableCell('c1') as string)
+              : getTableCell('c1') === p;
+          });
+        },
+        {p1: 'a'},
+      );
+
+      expect(queries.getResultTable('q1')).toEqual({r1: {c1: 'a'}});
+
+      queries.setParamValue('q1', 'p1', ['a', 'c', 'e']);
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r3: {c1: 'c'},
+        r5: {c1: 'e'},
+      });
+
+      queries.setParamValue('q1', 'p1', 'b');
+
+      expect(queries.getResultTable('q1')).toEqual({r2: {c1: 'b'}});
+    });
+
+    test('changes param from one array to another array', () => {
+      queries.setQueryDefinition(
+        'q1',
+        't1',
+        ({select, where, param}) => {
+          select('c1');
+          where((getTableCell) => {
+            const p = param('p1') as string[];
+            return p.includes(getTableCell('c1') as string);
+          });
+        },
+        {p1: ['a', 'c']},
+      );
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r3: {c1: 'c'},
+      });
+
+      queries.setParamValue('q1', 'p1', ['b', 'd']);
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r2: {c1: 'b'},
+        r4: {c1: 'd'},
+      });
+
+      queries.setParamValue('q1', 'p1', ['a', 'c']);
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r3: {c1: 'c'},
+      });
+    });
+
+    test('setting array param to equivalent array does not trigger', () => {
+      const listener = vi.fn();
+      queries.setQueryDefinition(
+        'q1',
+        't1',
+        ({select, where, param}) => {
+          select('c1');
+          where((getTableCell) => {
+            const p = param('p1') as string[];
+            return p.includes(getTableCell('c1') as string);
+          });
+        },
+        {p1: ['a', 'c']},
+      );
+
+      queries.addResultTableListener('q1', listener);
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r3: {c1: 'c'},
+      });
+
+      queries.setParamValue('q1', 'p1', ['a', 'c']);
+
+      expect(listener).not.toHaveBeenCalled();
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r3: {c1: 'c'},
+      });
+    });
+
+    test('setting primitive param to same value does not trigger', () => {
+      const listener = vi.fn();
+      queries.setQueryDefinition(
+        'q1',
+        't1',
+        ({select, where, param}) => {
+          select('c1');
+          where((getTableCell) => getTableCell('c1') === param('p1'));
+        },
+        {p1: 'a'},
+      );
+
+      queries.addResultTableListener('q1', listener);
+
+      expect(queries.getResultTable('q1')).toEqual({r1: {c1: 'a'}});
+
+      queries.setParamValue('q1', 'p1', 'a');
+
+      expect(listener).not.toHaveBeenCalled();
+      expect(queries.getResultTable('q1')).toEqual({r1: {c1: 'a'}});
+    });
   });
 
   describe('setParamValues', () => {
@@ -5098,6 +5216,33 @@ describe('Parameterized', () => {
 
       expect(queries.getResultRowIds('q1')).toEqual(['r2']);
     });
+
+    test('deletes param when missing from setParamValues', () => {
+      queries.setQueryDefinition(
+        'q1',
+        't1',
+        ({select, where, param}) => {
+          select('c1');
+          where(
+            (getTableCell) =>
+              getTableCell('c1') === param('p1') ||
+              getTableCell('c2') === param('p2'),
+          );
+        },
+        {p1: 'a', p2: 'even'},
+      );
+
+      expect(queries.getResultTable('q1')).toEqual({
+        r1: {c1: 'a'},
+        r2: {c1: 'b'},
+        r4: {c1: 'd'},
+      });
+
+      queries.setParamValues('q1', {p1: 'c'});
+
+      expect(queries.getResultTable('q1')).toEqual({r3: {c1: 'c'}});
+      expect(queries.getParamValues('q1')).toEqual({p1: 'c'});
+    });
   });
 
   describe('Listeners', () => {

test/unit/core/ui-react/hooks.test.tsx

@@ -2612,6 +2612,43 @@ describe('Read Hooks', () => {
     unmount();
   });
 
+  test('useParamValue with array changes', () => {
+    const queries = createQueries(store).setQueryDefinition(
+      'q1',
+      't1',
+      ({select, where, param}) => {
+        select('c1');
+        where((getTableCell) => {
+          const p = param('p1');
+          return Array.isArray(p)
+            ? (p as string[]).includes(getTableCell('c1') as string)
+            : getTableCell('c1') === p;
+        });
+      },
+      {p1: 'a'},
+    );
+    const Test = ({queryId, paramId}: {queryId: Id; paramId: Id}) =>
+      didRender(JSON.stringify(useParamValue(queryId, paramId, queries)));
+    const {container, rerender, unmount} = render(
+      <Test queryId="q1" paramId="p1" />,
+    );
+
+    expect(container.textContent).toEqual('"a"');
+
+    act(() => queries.setParamValue('q1', 'p1', ['a', 'c']));
+    expect(container.textContent).toEqual('["a","c"]');
+
+    act(() => queries.setParamValue('q1', 'p1', ['b', 'd']));
+    expect(container.textContent).toEqual('["b","d"]');
+
+    act(() => queries.setParamValue('q1', 'p1', 'e'));
+    expect(container.textContent).toEqual('"e"');
+
+    expect(didRender).toHaveBeenCalledTimes(4);
+
+    unmount();
+  });
+
   test('useSetParamValueCallback', () => {
     const queries = createQueries(store);
     queries.setQueryDefinition(